Repository navigation
fix(v8): keep llvm-libc src/string in V8 updates - #1242
Merged
Merged
Conversation
V8 now sets LIBC_MATH_NO_EXCEPT, but the vendored llvm-libc no longer uses system fenv.h. On MacOS this ends up requiring src/string/memory_utils/inline_memcpy.h, so we need to check them in. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/8705136 Refs: https://redirect.github.com/llvm/llvm-project/pull/224384
legendecas
approved these changes
Nov 6, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1242 +/- ##
=======================================
Coverage 66.52% 66.52%
=======================================
Files 69 69
Lines 14104 14105 +1
=======================================
+ Hits 9383 9384 +1
Misses 4721 4721 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V8 now sets LIBC_MATH_NO_EXCEPT, but the vendored llvm-libc no longer uses system fenv.h. On MacOS this ends up requiring src/string/memory_utils/inline_memcpy.h, so we need to check them in.
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/8705136
Refs: https://redirect.github.com/llvm/llvm-project/pull/224384