Skip to content

fix(examples): build asyncio_reduce image from the pynumaflow root - #392

Merged
vaibhavtiwari33 merged 1 commit into
numaproj:mainfrom
isaiah-harville:fix/asyncio-reduce-docker-build
Nov 18, 2026
Merged

vaibhavtiwari33 merged 1 commit into
numaproj:mainfrom
isaiah-harville:fix/asyncio-reduce-docker-build

Conversation

@isaiah-harville

@isaiah-harville isaiah-harville commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fixes the failing Docker Publish workflow on main (run 43249530240).

The examples/reduce/asyncio_reduce job fails with:

failed to calculate checksum of ref ...: "/pynumaflow": not found
make: *** [Makefile:11: image-push] Error 1

Its Dockerfile copies pyproject.toml, uv.lock, pynumaflow/ and the example from the package root. Its Makefile ran docker buildx build ... . from the example directory, so none of those paths were in the build context. The example joined the publish matrix in 58cb476 and has never built. Every other example's Makefile already does cd ../../../ && docker build -f ${DOCKER_FILE_PATH} .... This change makes asyncio_reduce do the same, and drops the stray quotes around IMAGE_REGISTRY.

How it was tested

  • make image on main reproduces the CI failure: "/pynumaflow": not found.
  • make image on this branch builds the image (native arm64, Docker Desktop). Starting Python in the container and importing pynumaflow.reducer and async_exec succeeds.
  • make -n image-push runs docker buildx build -f examples/reduce/asyncio_reduce/Dockerfile ... . from packages/pynumaflow.

Not run: the multi-arch (amd64 + arm64) buildx build and the push to Quay, which needs credentials. The next main push will confirm the Docker Publish job goes green.

🤖 Generated with Claude Code

The Dockerfile copies pyproject.toml, uv.lock and pynumaflow/ from the
package root, but the Makefile built with the example directory as the
context. Docker Publish failed on main with '/pynumaflow: not found'
since asyncio_reduce joined the publish matrix. Build from the package
root with -f, like the other examples.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Signed-off-by: isaiah-harville <[email protected]>
@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.99%. Comparing base (58cb476) to head (671df57).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #392   +/-   ##
=======================================
  Coverage   92.99%   92.99%           
=======================================
  Files          68       68           
  Lines        3654     3654           
  Branches      236      236           
=======================================
  Hits         3398     3398           
  Misses        190      190           
  Partials       66       66           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vigith
vigith changed the base branch from main to fix-failing-eg November 18, 2026 22:12
@vigith
vigith changed the base branch from fix-failing-eg to main November 18, 2026 22:12
@vaibhavtiwari33
vaibhavtiwari33 merged commit 1f585fb into numaproj:main Nov 18, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants