Repository navigation
fix: show shares in the system file picker - #264
Open
welcometopwn wants to merge 2 commits into
Open
welcometopwn wants to merge 2 commits into
welcometopwn wants to merge 2 commits into
Conversation
Contributor
|
Please have a closer look at the permissions. I was able to delete and rename shared documents and folders on the device (not on the server). |
Author
|
Fixed, thank you. Flags follow the server permissions now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #214
The documents provider only lists personal and project spaces at the account root, so shares can't be reached from the system file picker.
Fix
DocumentsStorageProvideradds the Shares root folder (GetSharesRootFolderForAccount, same as the Shares tab) to the account root, next to the spaces.SpaceCursor.addSharesRoot()builds that row: "Shares" as name, shared icon, no create flag since you can't add files to the Shares folder itself. Inside a share the usual permissions apply.Tested on a Galaxy S25+ (Android 17) with the Files app: Shares shows up next to Personal, the shared folders and their subfolders load and files open. detekt and the unit tests pass.