Repository navigation
test: start each retry of an integration test from a clean state - #265
Merged
Merged
Conversation
RetryRule now finishes the activities left over from the failed attempt, and LoginTest waits through NoActivityResumedException while SplashActivity hands over to LoginActivity. Before, the retry failed right away on the first step. Assisted-by: Claude Code:claude-opus-5-5
v-scharf
force-pushed
the
test/integration-retry-cleanup
branch
from
November 20, 2026 08:41
d13828b to
b6cb574
Compare
v-scharf
marked this pull request as ready for review
November 20, 2026 08:41
guruz
approved these changes
Nov 20, 2026
guruz
left a comment
Contributor
There was a problem hiding this comment.
I guess it's good :) seems to run through.
When merging please use merge+rebase.
thanks :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The retry of
LoginTestnever helped: when an attempt failed after login,FileDisplayActivityand the manage accounts dialog stayed open, becauseActivityScenarioRuleonly closes the activity it launched. The next attempt then failed on its first step within 2 s withNoActivityResumedException(see pipeline 221 on main).RetryRulefinishes all activities left over from a failed attempt before retrying.LoginTestkeeps waiting onNoActivityResumedExceptionwhileSplashActivityhands over toLoginActivity; it was not among Kaspresso's allowed exceptions.AI assistance: Claude Code (claude-opus-5-5) analysed the CI logs and wrote the change.