Skip to content

test: start each retry of an integration test from a clean state - #265

Merged
v-scharf merged 1 commit into
mainfrom
test/integration-retry-cleanup
Nov 20, 2026
Merged

v-scharf merged 1 commit into
mainfrom
test/integration-retry-cleanup

Conversation

@v-scharf

@v-scharf v-scharf commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

The retry of LoginTest never helped: when an attempt failed after login, FileDisplayActivity and the manage accounts dialog stayed open, because ActivityScenarioRule only closes the activity it launched. The next attempt then failed on its first step within 2 s with NoActivityResumedException (see pipeline 221 on main).

  • RetryRule finishes all activities left over from a failed attempt before retrying.
  • LoginTest keeps waiting on NoActivityResumedException while SplashActivity hands over to LoginActivity; it was not among Kaspresso's allowed exceptions.

AI assistance: Claude Code (claude-opus-5-5) analysed the CI logs and wrote the change.

RetryRule now finishes the activities left over from the failed
attempt, and LoginTest waits through NoActivityResumedException while
SplashActivity hands over to LoginActivity. Before, the retry failed
right away on the first step.

Assisted-by: Claude Code:claude-opus-5-5
@v-scharf v-scharf self-assigned this Nov 20, 2026
@v-scharf
v-scharf force-pushed the test/integration-retry-cleanup branch from d13828b to b6cb574 Compare November 20, 2026 08:41
@v-scharf
v-scharf marked this pull request as ready for review November 20, 2026 08:41
@v-scharf
v-scharf requested review from guruz and wernrab November 20, 2026 08:42

@guruz guruz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's good :) seems to run through.

When merging please use merge+rebase.

thanks :)

@v-scharf
v-scharf merged commit 8ef2fd8 into main Nov 20, 2026
4 checks passed
@v-scharf
v-scharf deleted the test/integration-retry-cleanup branch November 20, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants