Repository navigation
Conversation
The API server stores HPA metric target quantities in canonical form, so a desired averageValue of 1000 is stored as 1k and the dependent HPA was updated on every reconciliation. Normalise value and averageValue for all autoscaling/v2 metric sources, reusing the quantity check of PodTemplateSpecSanitizer. Fixes operator-framework#3681 Signed-off-by: Conor Gallagher <[email protected]>
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
Signed-off-by: Conor Gallagher <[email protected]>
… matcher The API server stores PersistentVolumeClaim template storage requests in canonical form, so a desired storage of 1024Mi is stored as 1Gi and the dependent StatefulSet was updated on every reconciliation. Normalise the volumeClaimTemplates resource requests with the shared quantity check used for pod template resources. Signed-off-by: Conor Gallagher <[email protected]>
cjbooms
force-pushed
the
fix/statefulset-vct-quantity-sanitizer
branch
from
November 6, 2026 17:09
2638bd6 to
5f1ec01
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The API server stores PersistentVolumeClaim template storage requests in canonical form, for example
1024Mias1Gi. The SSA matcher compares strings, so it reports a mismatch and the dependent StatefulSet is updated on every reconciliation. This is the same symptom as #3681, forStatefulSet.spec.volumeClaimTemplates[i].spec.resources.requests.Change
SSABasedGenericKubernetesResourceMatchersanitizeVolumeClaimTemplatesnormalisesresources.requestswithQuantitySanitizer.sanitizeQuantitiesfrom #3682.sample-sts-volumeclaimtemplates-desired-with-equivalent-storage.yaml1024Miagainst the actual1Gi. Added to the existing matching test parameters.StatefulSetDesiredSanitizerDependentResource1024Mistorage.Verification
StatefulSetDesiredSanitizerITon k3s v1.31.4 times out without the matcher change and passes with it.