Skip to content

docs: require signed-off commits in AGENTS.md - #3684

Merged
csviri merged 1 commit into
operator-framework:mainfrom
csviri:chore-agents-dco-signoff
Nov 6, 2026
Merged

csviri merged 1 commit into
operator-framework:mainfrom
csviri:chore-agents-dco-signoff

Conversation

@csviri

@csviri csviri commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Adds a note to the PR guidelines in AGENTS.md that commits must be signed off (git commit -s), since the DCO check fails otherwise. This makes AI agents sign off their commits.

Summary by CodeRabbit

  • Documentation
    • Updated contribution guidance to require signed-off commits. Commits missing a sign-off will fail the DCO check.
    • This change applies to the contribution workflow; it does not alter application behavior or add user-facing features.

Copilot AI balanced review requested due to automatic review settings November 6, 2026 18:49
@openshift-ci
openshift-ci Bot requested review from metacosm and xstefank November 6, 2026 18:49
@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

AGENTS.md adds a pull request guideline that requires commit sign-off with git commit -s and states that unsigned commits fail the DCO check.

Changes: Commit sign-off guidance

Layer / File(s) Summary
Document commit sign-off requirement
AGENTS.md
The guideline requires git commit -s and states that commits without a Signed-off-by line fail the DCO check.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: xstefank

Merge Risk: Minimal · up to 4e535

The change adds DCO sign-off guidance and presents no evident merge-blocking risk.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the requirement for signed-off commits in AGENTS.md.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ec79db8d-612d-465c-9522-ba9010b3df2f
Commits

Reviewing files that changed from the base of the PR and between 1b1a8e0 and 4e53555.

Files selected for processing: 1

  • AGENTS.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the guidelines update requiring DCO commit sign-offs.

No open issues 🎉

What changed in this PR

Updates the AI agent contribution guidelines to require commit sign-offs for DCO compliance.

Changes:

  • Adds git commit -s guidance and explains that commits without a Signed-off-by line fail the DCO check.
File Description
AGENTS.md Documents the commit sign-off requirement in the PR guidelines.

Review effort: Balanced

@csviri
csviri requested a review from gaborgsomogyi November 6, 2026 19:03
@csviri
csviri merged commit 31fc7da into operator-framework:main Nov 6, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants