Skip to content

chore: update libinjection to v4.0.2 - #3767

Merged
fzipi merged 2 commits into
owasp-modsecurity:v3/masterfrom
airween:v3/libinjection-4.0.2
Nov 16, 2026
Merged

fzipi merged 2 commits into
owasp-modsecurity:v3/masterfrom
airween:v3/libinjection-4.0.2

Conversation

@airween

@airween airween commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

what

Updated libinjection submodule to 4.0.2.

why

It's been released with a SQLi detection fix: MySQL charset introducers that were missing from the keyword table (_utf8mb4, _utf16, _gb18030 and others, and _ucs2, which was misspelled as _usc2) are now recognized (libinjection/libinjection#101).

Also fixes the version the bundled library reports. others/Makefile.am compiled libinjection with -D LIBINJECTION_VERSION="${LIBINJECTION_VERSION}", but that make variable was always empty (configure.ac defines it only as an m4 macro for the configure summary). libinjection 4.x defines LIBINJECTION_VERSION inside #ifndef, so libinjection_version() returned "" in every autotools build. The -D and the empty AC_SUBST are removed; libinjection_version() now returns 4.0.2, and the configure summary still prints v4.0.2. The Windows CMake build sets its own value and is unchanged.

references

AI disclosure

Made with help of Claude Code (Opus 5.5)

Summary by CodeRabbit

  • Chores
    • Updated a bundled component to a newer version. No user-visible changes were specified for this update. The accompanying build configuration adjustments do not describe changes to app features or behavior, so no additional user-facing updates are noted.

AI disclosure: made with help of Claude Code, Opus 5.5
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The others/libinjection submodule reference changed to commit 7244a1e3c633ea13b3c89d2f670da25789e152fc. The Autotools configuration no longer registers LIBINJECTION_VERSION for substitution or defines it in libinjection compiler flags.

Changes: libinjection build integration

Layer / File(s) Summary
Update libinjection and build configuration
others/libinjection, configure.ac, others/Makefile.am
The submodule reference now points to commit 7244a1e3c633ea13b3c89d2f670da25789e152fc. The build configuration no longer registers LIBINJECTION_VERSION for substitution or defines it in libinjection compiler flags.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

Suggested reviewers: fzipi, eduar-hte

Merge Risk: Minimal · up to 69718

This updates libinjection to v4.0.2 so that missed MySQL charset introducers are detected, and it drops an unneeded version define from the Autotools build. No concrete merge-blocking risk was found. Normal CI build checks should confirm that the build still works.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "chore: update libinjection to v4.0.2" matches the main change. The PR updates the libinjection submodule from one commit to another, and the objectives state the update targets the v4.0.2 r…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title "chore: update libinjection to v4.0.2" matches the main change. The PR updates the libinjection submodule from one commit to another, and the objectives state the update targets the v4.0.2 release. The title does not mention the build-system change that removes the LIBINJECTION_VERSION definition, but that change is secondary and the title does not need to cover every detail.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cdb52827-cc45-423c-a995-09e00a15808a
Commits

Reviewing files that changed from the base of the PR and between 8e57110 and 697183b.

Files selected for processing: 2

  • configure.ac
  • others/Makefile.am
Files with no reviewable changes: 2

  • configure.ac
  • others/Makefile.am

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

@airween airween added the 3.x Related to ModSecurity version 3.x label Nov 16, 2026
others/Makefile.am compiled libinjection with
-D LIBINJECTION_VERSION="${LIBINJECTION_VERSION}", but that make variable
was always empty: configure.ac defines LIBINJECTION_VERSION only as an m4
macro (used in the configure summary), and the AC_SUBST of it never
received a value. libinjection 4.x defines LIBINJECTION_VERSION itself
inside #ifndef, so the empty definition won and libinjection_version()
returned "" in every autotools build.

Drop the -D and the empty AC_SUBST, so libinjection uses its own version
string, kept in sync with its release by release-please. The configure
summary still prints the version from git describe. The Windows CMake
build passes its own value and is not changed.

AI disclosure: made with help of Claude Code, Opus 5.5
@sonarqubecloud

Copy link
Copy Markdown

@fzipi
fzipi merged commit 3921e8e into owasp-modsecurity:v3/master Nov 16, 2026
103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x Related to ModSecurity version 3.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants