Repository navigation
add the posthog plugin - #129
Merged
Merged
Conversation
Read the "Fix removed APIs" table of posthog-python's 7.x to 8.0 migration guide at tag posthog-v8.0.0 with removedmembers, which now reads Markdown pipe tables as well as RST ones (NumPy's golden is unchanged). 8 events: one renamed_symbol (CaptureV1Error to CaptureError) and seven removed_symbol; an environment variable, an argument value and two rows of prose are dropped and logged. Signed-off-by: brandonphelps1212 <[email protected]> Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: brandonphelps1212 <[email protected]>
…ure_mode, which still works Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: brandonphelps1212 <[email protected]>
|
Claude finished @brandonphelps1212's task in 1m 31s —— View job ✅ Ready to merge: the plugin follows every repo rule, its 7 events match the saved guide's table, and build, vet, gofmt, the tests and the leak guard all pass. Rules
BugsNone found. What I checked:
Verified
Non-blocking
|
…ort gap Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: brandonphelps1212 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Adds
posthogon theremovedmembersformat plugin, which learns Markdown tables. Part of #79 (I12.3 · Watch PostHog), under #15.docs/migration-7.x-to-8.0.mdat tagposthog-v8.0.0(commit 6edff41). It's MIT and saved whole, byte-identical to the tag. It's unchanged at 8.0.2 and absent at 7.91.4. The plugin reads its### Fix removed APIstable (| Removed | Use instead |).removedmemberslearns Markdown pipe tables (markdown.go), with optionalGuidefields:Tag,Format,Header,Effect,EnvVars,NewReplacements,Paths,StillWork. Empty values keep the old behavior: NumPy's golden is byte-identical, and the scaffolder's tests pass.package_releaseevents, version8.0.0(a package version, so the client's package gate handles it):removed_symbolforCaptureMode,capture_v1,capture_v1.CaptureV1Error,request.batch_post,_async_request.async_batch_post,request.EVENTS_ENDPOINTandrequest.AI_EVENTS_ENDPOINT.NewReplacements): every replacement is new in 8.0.0, andCaptureErroralso moves module, so a rename fix would break on 7.x. Each replacement stays in the migration hint.Paths): the table writesrequest.batch_post, async_batch_post, EVENTS_ENDPOINTin one cell, but only the first is spelled out. The paths are checked againstreferences/public_api_snapshot.txtand the code atposthog-v7.91.4.capture_mode(StillWork): the guide's own "Rename deprecated settings" table saysposthog.capture_modestill works or has no effect in 8.x.x;POSTHOG_CAPTURE_MODE: an environment variable;gzip=True: an argument value of an unnamed call;gzipparameter of …": prose;request.postandrequest.flagstake**kwargs, so it raises nothing;backoffdependency".Checklist
docs/plugins.md: new row (LayerSDK, statuslive).posthogis added to the pinned-releases line,docs/plugins.jsonis regenerated, and the README badge is 22. I compared the registered plugins with the table.plugins/removedmembers/testdata/golden/posthog-8.0.0.json).testdata/README.mdrow: URL at the tag, date, license (MIT), quote.providers/posthog.mdfrom the template, including Why this source.env.Get.make checkpasses.Notes for the reviewer
us.posthog.com/api/schema/), never committed, so there's nothing to pin or replay./api/environments/aliases of/api/projects/.capture_modecontradiction, and both are fixed here. TheCaptureV1Errorrename → removal change came from an earlier check.🤖 Generated with Claude Code