Repository navigation
add the neon plugin - #132
Merged
Merged
Conversation
Watches the Neon API spec in neondatabase/neon-pkgs (packages/sdk/spec/neon-openapi.json), pinned per commit and versioned by commit date. Keeps operation deprecations and removals of operations marked deprecated first. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: brandonphelps1212 <[email protected]>
Move the server's /api/v2 into the paths with Sentry's helper, now shared (adapter.ServerBasePath), so a spec that moves it can't read as every deprecated operation removed; and accurate wording on what says deprecated. Signed-off-by: brandonphelps1212 <[email protected]> Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
Claude finished @brandonphelps1212's task in 1m 54s —— View job ✅ Ready to merge: the plugin follows every rule, I found no wrong event in what it reads, and build, vet, gofmt, the tests and the leak guard all pass locally. Two things need a maintainer's decision before merging (the test data's license and the client change). Neither is a code problem. Rules
BugsNone found. What I checked:
Verified
I did not run For the maintainers (please decide)
Non-blocking
Thanks for a careful, well-documented PR. Testing with the filter turned off and the separate test of a kept removal are especially useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Adds
neon, anopenapiplugin for Neon's management API. Part of #74 (I11.6 · Watch Neon), under #14.packages/sdk/spec/neon-openapi.jsonin neondatabase/neon-pkgs, read at the newest commit that changed it. A daily drift check against the live spec (https://neon.com/api_spec/release/v2.json) keeps it current.versionis the commit date (YYYY-MM-DD). The API has no version of its own:info.versionisv2in all 23 commits.deprecationsOnly. Deprecations come from thedeprecatedflag, with the operation quoted (QuoteDeprecatedOperation), so the "use X instead" and "Removal scheduled" text is cited. A removal is kept only if the operation was flagged first./api/v2(POST /api/v2/projects/…), the path a caller sends. The spec's server ishttps://console.neon.tech/api/v2. Sentry's helper that moves the server path into the paths is now shared (adapter.ServerBasePath,adapter.BasePathPointer). Sentry's goldens are unchanged./api/v2(as Sentry's did in November) would read as all 16 deprecated operations removed: 16 false breaking events.POST /api/v2/projects/{project_id}/branches/{branch_id}/auth/send_test_email, deprecated on 2026-08-23. The 1 unmarked removal (…/recover, which Neon's PR #408 says still routes) is dropped.For the maintainers: the test data's license
The repo is Apache-2.0, but the spec's own
info.licensesays "Proprietary". So the test data is trimmed excerpts: the operations the tests need, every kept line unchanged, withinfo.contactleft out. The extra removal test uses the same spec from the MIT@neondatabase/api-clientnpm package. Please confirm that's acceptable.Needs a client change
neonmust be added to the patch-it client's list of date-versioned APIs, likesupabaseandsentry. Until then the client can't place these events. That's a separate PR in the client repo.Checklist
docs/plugins.md: new row, statuslive.docs/plugins.jsonregenerated, README badge 25. I compared the row's words with the plugin.5c57d009→93b93dc9, 1 deprecation event.4c6b3be4→4497de89, the unmarked removal of…/recover, 0 events. With the filter off it gives exactly that 1 removal, so the test isn't vacuous.@neondatabase/api-client2.7.2 → 2.7.3, the removal ofGET /api/v2/consumption_history/account. It was flagged deprecated first and is confirmed by Neon's changelog. This is a different source, labelled as such.testdata/README.mdrows: URL at the commit, date, license, quote.providers/neon.mdfrom the template, with Why this source and Known gaps:make checkpasses.Notes for the reviewer
An independent review re-derived every number from all 23 commits, the live spec and both npm tarballs.
🤖 Generated with Claude Code