Repository navigation
the plugins rewrite: core/, providers and sources, no committed lists, versions (#183–#210) - #211
Merged
Merged
Conversation
core/ holds what isn't one kind: the plugin contract and registry, fetch, kit and kittest, the event types, migrate, and the OpenAPI diff engine with normalize and hint. The spec adapters move to plugins/openapi/adapter, the deprecations-page reader to plugins/retirements/retire and the migration guide reader to plugins/migrationguide/sdkguide. The old import paths that patch-it's hosted ingestion service uses (plugin, event, fetch, migrate, kit, kit/kittest, retire, sdkguide) stay as deprecated packages that only forward to the new ones. The newest-release, newest-commit-on-a-path and commit-date lookups that nine adapters, apichangelog and catalog each decoded themselves are now one helper, core/github. Also regenerates docs/plugins.json and the README badge (out of date on main since the salesforce plugin) and gofmts vercel_test.go. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
A plugin is now registered as a source of its provider:
plugin.RegisterProvider(Provider{ID, Name, Category, Homepage, Sources:
[]Source{ID, Kind, Layer, Watches, URLs, Page, Plugin}}). Source ids are
provider/source (stripe/api, algolia/search-api, openai/models); the old
slugs stay as aliases, so Lookup and LookupSource resolve both, Names() still
lists the old slugs, and events keep the old api value until patch-it's
change-event contract switches to source ids.
The three Algolia plugins are one provider with three sources. Every provider
has a category. RegisterProvider refuses incomplete metadata; a test checks
every registered plugin is a source whose page exists, and the docs table
must match the registrations word for word until it goes.
new-plugin writes a RegisterProvider block, reusing an existing provider's
metadata.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: adssib <[email protected]>
docs/plugins.md and docs/plugins.json are gone, with the README's coverage table and plugin-count badge and the providers/ page table. The registry is the only list: go run ./cmd/list-plugins (make plugins) prints every provider and source with its metadata as JSON (docs/plugins.schema.json), and the Release workflow attaches that output to each release as plugins.json. AGENTS.md rule 1 is now: every new or changed provider or source has complete metadata in its registration, and a providers/ page. new-plugin no longer writes a table row; the PR template and the review prompts check the registration instead. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
A versioned source now has three parts next to Run: ListVersions (every version, oldest first), ReadAt (the source at one version) and Extract (the changes between two snapshots, with previous_version set). Run keeps working and is built from them. core/versions lists versions from GitHub releases, tags and commits, PyPI, npm and the Web Archive at a date, with one version ordering. openapi: every adapter whose LatestTag was releases/latest or the newest commit on its spec can list all of them (Stripe, Datadog, Vercel, Flagsmith, Supabase, Neon, Convex, PlanetScale); the rest list their newest. changelog, migrationguide and removedmembers no longer pin a tag: releases come from PyPI and each is read at its tag; the pinned releases stay as the goldens' cases. Every golden is byte-identical. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
The README says what the repo is in two lines, adds a provider in three steps and links docs/. How a plugin works, the layout, the checks and releases move to docs/how-it-works.md. writing-a-plugin.md covers providers, sources, kinds and layers, registering with RegisterProvider, and reading a source version by version (ListVersions, ReadAt, Extract, core/versions). The README template is one screen too, and never lists what's covered. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
gofmt versions disagree on how to align the old map literal, so CI's gofmt failed on what a newer one wrote. Two lists need no alignment. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugins rewrite in one PR. This is the top of the stack, so it contains, unchanged:
core/, readers under their kind, one "find newest on GitHub" helperplugins.jsonListVersions,ReadAt,Extract; no pinned tags in registered sourcesdocs/Review and merge this one instead of the five. When it merges, #183, #184, #208, #209 and #210 show as merged by themselves.
Every golden file is byte-identical to
main(all 36). Details and test results are in each PR above.After merging: run the Release workflow by hand with minor (v0.3.0). That release carries
plugins.json, which patch-it-dev/patch-it-docs#12 reads.🤖 Generated with Claude Code