Repository navigation
test: pass on PHP builds without OPcache loaded - #2828
Merged
Merged
Conversation
TestEnvVarsInPhpIni checks environment variable expansion in php_ini, which works the same for any directive. Reading opcache.enable made it fail on PHP < 8.5 builds where OPcache is a shared extension that isn't loaded.
PHP < 8.5 builds OPcache as a shared extension by default, so a build following the compile docs fails these tests unless a php.ini loads it. Skip them like the hot reload test already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On PHP < 8.5, OPcache is a shared extension by default. A build that follows https://frankenphp.dev/docs/compile/ does not load it, and four tests fail:
TestEnvVarsInPhpIni,TestOpcachePreload_module,TestOpcachePreload_workerandTestOpcacheReset(Caddy). CI is not affected because setup-php loads OPcache.TestEnvVarsInPhpInionly checks environment variable expansion inphp_ini, so it now readsdefault_socket_timeoutinstead ofopcache.enable.opcache_reset()tests skip when OPcache is not loaded, like the hot reload test already does.