Skip to content

Fix GH-25340: ReflectionEnumBackedCase::getBackingValue() on non-backed case #25343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lazerg wants to merge 3 commits into
base: PHP-8.4
Choose a base branch
from
+69 −29
Open

Fix GH-25340: ReflectionEnumBackedCase::getBackingValue() on non-backed case #25343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3bb612
Fix GH-25340: ReflectionEnumBackedCase::getBackingValue() on non-back…
lazerg Nov 9, 2026
55aaf38
Use the not-a-case message for non-case constants
lazerg Nov 9, 2026
f2d694a
Check enum cases in ReflectionClassConstant::__construct() instead
lazerg Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 13 additions & 29 deletions ext/reflection/php_reflection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3975,6 +3975,18 @@ ZEND_METHOD(ReflectionClassConstant, __construct)
RETURN_THROWS();
}

if (instanceof_function(Z_OBJCE_P(object), reflection_enum_unit_case_ptr)) {
if (!(ZEND_CLASS_CONST_FLAGS(constant) & ZEND_CLASS_CONST_IS_CASE)) {
zend_throw_exception_ex(reflection_exception_ptr, 0, "Constant %s::%s is not a case", ZSTR_VAL(constant->ce->name), ZSTR_VAL(constname));
RETURN_THROWS();
}

if (instanceof_function(Z_OBJCE_P(object), reflection_enum_backed_case_ptr) && constant->ce->enum_backing_type == IS_UNDEF) {
zend_throw_exception_ex(reflection_exception_ptr, 0, "Enum case %s::%s is not a backed case", ZSTR_VAL(constant->ce->name), ZSTR_VAL(constname));
RETURN_THROWS();
}
}

if (intern->ptr) {
zval_ptr_dtor(reflection_prop_name(object));
zval_ptr_dtor(reflection_prop_class(object));
Expand Down Expand Up @@ -7749,20 +7761,6 @@ ZEND_METHOD(ReflectionEnum, getBackingType)
ZEND_METHOD(ReflectionEnumUnitCase, __construct)
{
ZEND_MN(ReflectionClassConstant___construct)(INTERNAL_FUNCTION_PARAM_PASSTHRU);
if (EG(exception)) {
RETURN_THROWS();
}

reflection_object *intern;
zend_class_constant *ref;

GET_REFLECTION_OBJECT_PTR(ref);

if (!(ZEND_CLASS_CONST_FLAGS(ref) & ZEND_CLASS_CONST_IS_CASE)) {
zval *case_name = reflection_prop_name(ZEND_THIS);
zend_throw_exception_ex(reflection_exception_ptr, 0, "Constant %s::%s is not a case", ZSTR_VAL(ref->ce->name), Z_STRVAL_P(case_name));
RETURN_THROWS();
}
}

ZEND_METHOD(ReflectionEnumUnitCase, getEnum)
Expand All @@ -7780,21 +7778,7 @@ ZEND_METHOD(ReflectionEnumUnitCase, getEnum)

ZEND_METHOD(ReflectionEnumBackedCase, __construct)
{
ZEND_MN(ReflectionEnumUnitCase___construct)(INTERNAL_FUNCTION_PARAM_PASSTHRU);
if (EG(exception)) {
RETURN_THROWS();
}

reflection_object *intern;
zend_class_constant *ref;

GET_REFLECTION_OBJECT_PTR(ref);

if (ref->ce->enum_backing_type == IS_UNDEF) {
zval *case_name = reflection_prop_name(ZEND_THIS);
zend_throw_exception_ex(reflection_exception_ptr, 0, "Enum case %s::%s is not a backed case", ZSTR_VAL(ref->ce->name), Z_STRVAL_P(case_name));
RETURN_THROWS();
}
ZEND_MN(ReflectionClassConstant___construct)(INTERNAL_FUNCTION_PARAM_PASSTHRU);
}

ZEND_METHOD(ReflectionEnumBackedCase, getBackingValue)
Expand Down
56 changes: 56 additions & 0 deletions ext/reflection/tests/gh25340.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
--TEST--
GH-25340 (ReflectionEnumBackedCase can be used on a non-backed enum via a constructor trick)
--CREDITS--
ndossche
--FILE--
<?php

class Plain { const X = 1; }

enum NotBacked { case A; }

enum Backed: int {
case A = 1;
const C = 2;
}

class U extends ReflectionEnumUnitCase {
public function __construct($class, $const) {
ReflectionClassConstant::__construct($class, $const);
}
}

class B extends ReflectionEnumBackedCase {
public function __construct($class, $const) {
ReflectionClassConstant::__construct($class, $const);
}
}

foreach ([[U::class, 'Plain', 'X'], [B::class, 'NotBacked', 'A'], [B::class, 'Backed', 'C']] as [$reflector, $class, $const]) {
try {
new $reflector($class, $const);
} catch (ReflectionException $e) {
echo $e->getMessage(), "\n";
}
}

$r = new B('Backed', 'A');
var_dump($r->getEnum()->name, $r->getValue(), $r->getBackingValue());

try {
$r->__construct('NotBacked', 'A');
} catch (ReflectionException $e) {
echo $e->getMessage(), "\n";
}
var_dump($r->getBackingValue());

?>
--EXPECT--
Constant Plain::X is not a case
Enum case NotBacked::A is not a backed case
Constant Backed::C is not a case
string(6) "Backed"
enum(Backed::A)
int(1)
Enum case NotBacked::A is not a backed case
int(1)
Loading