You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(mobile): disabled secondary buttons no longer look enabled - #35362
On mobile, a disabled button with the secondary tone (the default) looks enabled. The disabled background subtle-strong and the secondary background are the same colour in every theme, so only the label colour changes. Reproduce it on a server browser tab another viewer controls: mobile shows "Another viewer has control" next to a Take control button that looks pressable but does nothing.
Change
Disabled shared Buttons on iOS and Android now render at 50% opacity, on top of their existing disabled colours. That matches the disabled:opacity-50 other mobile controls already use, so a disabled secondary button no longer matches an enabled one. A loading button isn't dimmed, so a busy action doesn't look unavailable.
Scope
A small fix for an obvious bug, so no issue. A disabled control that looks enabled misleads the user. Tapping a disabled button still does nothing, and nothing else changes behaviour.
This is separate from #33398 / #33399, which change whether a viewer can take control from another device. This PR only makes the existing disabled state visible and doesn't depend on that change.
Verification
Reproduced on an Android emulator (Pixel 9, Android 17) against a local dev server. A web client held control of a server browser tab while the app viewed the same tab. The captures show the control bar before (left) and after (right), in light (top) and dark (bottom). Before, Take control looks the same as an enabled button. After, it is clearly unavailable.
vp run check:changed passed (format, lint, knip, typecheck, React compiler). It's a visual-only fix, so it has no test.
Not checked: iOS on a device. No simulator was available, so the iOS opacity-50 class is covered only by typecheck and lint. This also dims every other disabled shared Button on mobile. That's intended, but I only looked at this screen.
Implemented with Claude Opus 5.5 through Claude Code in T3 Code.
Macroscope's review found this PR approvable — Disabled mobile buttons now render at 50% opacity in both implementations. This is a presentation-only change that preserves existing interaction and accessibility behavior.
You can add or adjust custom eligibility rules. Learn more.
Reviewing files that changed from the base of the PR and between dfccf97 and 92df50f.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Walkthrough
The Android and shared mobile Button components now apply reduced opacity when disabled. The shared Button does not apply this opacity when loading alone.
Changes: Mobile button states
Layer / File(s)
Summary
Apply opacity when disabled apps/mobile/src/components/ui/Button.android.tsx, apps/mobile/src/components/ui/Button.tsx
The Android wrapper retains its existing layout styles and adds reduced opacity when disabled. The shared Button adds opacity-50 when disabled; loading alone does not apply it.
Disabled buttons on mobile now render dimmed so they look different from enabled ones. The change is small and visual-only, and no merge-blocking risk was found.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the main change: disabled secondary buttons in the mobile app no longer look enabled. The changeset adds a 50% opacity to disabled shared Button components on Android and iOS, so the t…
Description check
The description follows the template. It has Problem, Change, Scope, and Verification sections. The Problem section explains the bug and its reproduction context. The Change section explains the opaci…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: disabled secondary buttons in the mobile app no longer look enabled. The changeset adds a 50% opacity to disabled shared Button components on Android and iOS, so the title matches the primary change. It uses the conventional commit format and omits the wider scope (all disabled shared buttons), which is acceptable.
Full details: Description check
Explanation
The description follows the template. It has Problem, Change, Scope, and Verification sections. The Problem section explains the bug and its reproduction context. The Change section explains the opacity fix and why loading buttons are not dimmed. The Scope section justifies no linked issue for a small obvious bug and says the change is separate from related PRs. The Verification section gives the emulator reproduction, before/after screenshots, the commands run, and what was not checked (iOS device). The model and harness are named at the end, as the template asks.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Reviewing files that changed from the base of the PR and between fd8e386 and dfccf97.
Files selected for processing: 2
apps/mobile/src/components/ui/Button.android.tsx
apps/mobile/src/components/ui/Button.tsx
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
The automated pipeline stopped on this pull request and will not merge it:
these checks fail on 92df50f, also when run again: Agent context budget, and the rework changed nothing:
The only item was the failing 'Agent context budget' check, and it has nothing to do with this PR's code. The PR changes only apps/mobile/src/components/ui/Button.tsx and Button.android.tsx and never touches apps/server/src/provider/agentContextBudget.json. CI's merge commit (PR merged into base 0702c6f) carried that base's mcpToolListJsonBytes of 57751. While CI ran, main had just landed b985057 (#39947), which cut the value to 57696, so the comparison showed +55. I reproduced this locally with the check's own jq comparison: against b985057 it prints 'mcpToolListJsonBytes: 57696 -> 57751 (+55)', and against current origin/main (58405) it reports no growth. I changed and pushed nothing. Rerunning the check, or GitHub building a fresh merge ref, should make it pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:XS0-9 changed lines (additions + deletions).takeover:blockedTakeover blocked; reason in the PR bodyvouch:trustedAuthor is trusted by repo permissions or the VOUCHED list.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On mobile, a disabled button with the
secondarytone (the default) looks enabled. The disabled backgroundsubtle-strongand thesecondarybackground are the same colour in every theme, so only the label colour changes. Reproduce it on a server browser tab another viewer controls: mobile shows "Another viewer has control" next to a Take control button that looks pressable but does nothing.Change
Disabled shared
Buttons on iOS and Android now render at 50% opacity, on top of their existing disabled colours. That matches thedisabled:opacity-50other mobile controls already use, so a disabled secondary button no longer matches an enabled one. Aloadingbutton isn't dimmed, so a busy action doesn't look unavailable.Scope
A small fix for an obvious bug, so no issue. A disabled control that looks enabled misleads the user. Tapping a disabled button still does nothing, and nothing else changes behaviour.
This is separate from #33398 / #33399, which change whether a viewer can take control from another device. This PR only makes the existing disabled state visible and doesn't depend on that change.
Verification
Reproduced on an Android emulator (Pixel 9, Android 17) against a local dev server. A web client held control of a server browser tab while the app viewed the same tab. The captures show the control bar before (left) and after (right), in light (top) and dark (bottom). Before, Take control looks the same as an enabled button. After, it is clearly unavailable.
vp run check:changedpassed (format, lint, knip, typecheck, React compiler). It's a visual-only fix, so it has no test.Not checked: iOS on a device. No simulator was available, so the iOS
opacity-50class is covered only by typecheck and lint. This also dims every other disabled sharedButtonon mobile. That's intended, but I only looked at this screen.Implemented with Claude Opus 5.5 through Claude Code in T3 Code.