Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The plugin declares support for the Content Security Policy sent by GLPI.
Audit of the PHP, Twig and JavaScript sources found no inline event handler attribute, no
javascript:URL, no<script>tag printed from PHP or created from JavaScript, and no core helper emitting an inline handler, so no code change was needed.The LDAP select question passes
on_changetoDropdown::show(). Core renders it as jQuerychangehandler evaluated witheval(), not as anonchangeattribute, so it is allowed by the CSP ('unsafe-eval') and left unchanged.Changes
setup.php: add'csp_compliant' => truetoplugin_version_advancedforms().CHANGELOG.md: entry under Unreleased.Blocked by
csp_compliantdeclaration only takes effect on GLPI releases shipping the CSP.PLUGIN_ADVANCEDFORMS_MIN_GLPI_VERSION, currently 11.0.7) must be bumped to the first CSP-enabled 11.0 release before merging.Manual test checklist
Keep the browser console open. CSP violations appear as
Refused to execute inline event handlerorRefused to execute inline script.GetAuthLdapFilter). Select the empty value; the filter is cleared.