Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The plugin no longer relies on inline event handlers,
javascript:URLs or<script>tags printed from PHP, so it keeps working under the Content Security Policy sent by GLPI.Behaviour is unchanged: the same functions are called, the listeners are attached from
<script>blocks printed right after the markup.The plugin declares
csp_compliantinplugin_version_fields().Converted patterns
inc/container.class.php(showFormSubtype()): two<script>tags printed from PHP are now built withHtml::scriptBlock().inc/field.class.php(showForm()field list): the "Add a new field" link usedhref="javascript:viewAddField...()"; it is nowhref="#"with a click listener (preventDefault()) attached in the script block that definesviewAddField....inc/labeltranslation.class.php(showTranslations()):href="javascript:addTranslation...()"; it is nowhref="#"with a click listener attached in the same script block.onClickattribute; the row now has an id and the listener is attached in the per-row script block.setup.php:'csp_compliant' => trueadded toplugin_version_fields().CHANGELOG.md: entry under Unreleased.Not changed: literal
<script>blocks in the Twig templates (templates/forms/status_override.html.twig,templates/forms/status_overrides.html.twig,templates/container_display_conditions.html.twig,templates/question_type_administration.html.twig), which receive the nonce at compile time.Blocked by
Html::scriptBlock().PLUGIN_FIELDS_MIN_GLPI) must be raised to the first CSP-enabled release before merging.Manual test checklist
Keep the browser console open: a CSP violation shows as
Refused to execute inline event handlerorRefused to execute inline script.