Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
Make the plugin compatible with the Content Security Policy sent by GLPI (
script-src 'nonce-...' 'unsafe-eval') and declare it with'csp_compliant' => true.Behaviour is unchanged: the two inline handlers of the migration status page are replaced by data attributes bound from the page's existing script.
Converted patterns:
templates/migration_status.html.twig:oninput="glpiGenericobjectUpdateCounter(this)"on the rename input becomesdata-genericobject-update-counter, bound by a delegatedinputlistener.templates/migration_status.html.twig:onclick="copyCode()"on the copy button becomesdata-genericobject-copy-code, bound by a delegatedclicklistener.setup.php:'csp_compliant' => trueadded toplugin_version_genericobject().CHANGELOG.md: entry added under Unreleased.Not changed: the
<script>block ofmigration_status.html.twigis literal Twig text, so it receives the nonce at compilation.Blocked by
Manual test checklist
Keep the browser console open: CSP violations are reported there as
Refused to execute inline event handlerorRefused to execute inline script.plugins/genericobject/front/migration_status.php): the page loads with no CSP error in the console.php bin/console migration:genericobject_plugin_to_coreis copied and the button shows "Copied" for 2 seconds, then reverts.Refused to execute inline event handlermessage on the page.