Repository navigation
Conversation
Apply the reset fixes from ps2dev#70 while relying on ps2dev/ps2sdk#969 to reset newlib-nano stdio state during startup after ExecPS2. Co-authored-by: kaisa847 <[email protected]>
fjtrujy
marked this pull request as ready for review
November 18, 2026 15:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #70, incorporating its reset fixes without mirroring newlib-nano's private
struct _reentlayout in ps2link.ps2sdk #969 is merged. After
ExecPS2(), crt0 calls libcglue's__locks_init(), which now resets stdio state for both full newlib and newlib-nano. This removes ps2link's duplicate struct and direct_impure_ptrwrite.The reset fixes originate from @kaisa847's #70 and are credited in the single squashed commit. This is an alternative to #70, not an additional change to merge alongside it.
Validation: Full local EE/IOP/packed-ELF build passes with
-Werror. Hardware regression testing still needs ps2sdk rebuilt atcf9557dor later; the locally installed libcglue predates #969.Closes #70