Repository navigation
pstack 0.15.46 / upstream 0b46ec399d55 (#1283 #1284 #1292) - #75
Conversation
Bump the plugin pin and port the statechart Windows and CRLF changes from upstream 0b46ec399d55 (#1292). Leave the Gemini 4 Neon slug rewrite (#1283, #1284) out of the Droid skill text, which has no Gemini seat. Co-authored-by: Kaitian Xie <[email protected]>
Harness proofHead Secret forwarding
InstallCommands use the CI branch pin (
Statechart tests from that installed copy
The skip is Skill load (
|
| file | sha256 |
|---|---|
skills/statechart/SKILL.md |
ca7b3e43b1ddc4fb2425a33960f9390357323a869e1d921b6e2aff4f3004d55e |
skills/statechart/scripts/frontends/dot.ts |
cd2e681ff58c759ddeaa17c2f3d4af1f0c3e71273566be555187b5d0e7767dac |
skills/statechart/scripts/janitor.ts |
defac41e4cbfca3044c5078c544a0667f857a610c500c5ec96cb3bfaeec7120b |
skills/statechart/scripts/kill.ts |
058df69d1184029e55d7e81b4fd37a6dc8557c9208979fb7032482d5ab0db448 |
skills/statechart/scripts/run.ts |
fb6ec4a1835a15e6e72df28bb932b8df5a4c04c5de6f9c270fd63ff5cd148dc7 |
skills/statechart/scripts/statechart.ts |
5d5feff7d78204c828a8e30d531d23419234a81a7149dc3e48efb08dd770d6c1 |
skills/statechart/scripts/test/cli.test.ts |
7201a0eece44078a27f85880e2118c69bbfa072fbb9770af1db64442f03970a7 |
skills/statechart/scripts/test/messages.test.ts |
70dc23d0a9c76e9949f052c8f426d35463a1416aca2457d09de544654d0f5721 |
skills/statechart/SKILL.md line 19:
`scripts/statechart.ts` is TypeScript, so run it with a runtime that can execute TypeScript. `scripts/statechart` is a POSIX shell script that picks one. On native Windows, run `node --disable-warning=ExperimentalWarning <skill dir>/scripts/statechart.ts` with Node 22.18 to 22.x, or Node 23.6 or later.
scripts/frontends/dot.ts:
export const splitLines = (text: string) =>
(text.endsWith("\r") ? text.slice(0, -1) : text).split(/\r?\n/);scripts/janitor.ts spares a reused Windows pid after the worker exits:
const running = !input.includes("exited");
const groupOutlivesWorker = process.platform !== "win32";
if (running || groupOutlivesWorker) await killGroup(Number(pid));scripts/kill.ts uses taskkill on Windows and does not call /bin/sh.
Skills left on the Droid text (no Gemini 4 Neon seat, no gemini-4-neon-xhigh, no gemini-4-carbon-high). Hashes match this head:
| file | sha256 |
|---|---|
skills/arena/SKILL.md |
e2d7f0f2277f26d901b38218dd0419e4baa037c39d568466d8722c008b21a21b |
skills/poteto-mode/SKILL.md |
02647c723ff6032c3eedbc31f92bcde049e7472a12a907a989841dcff42da8fd |
skills/setup-pstack/SKILL.md |
dc7b7d582cee5c5cd8cc67530e354d36c521fe5f81accabfac85c705077fcd96 |
Installed excerpts:
- arena default runners: judgment seat
claude-fable-5-2(poteto-judgment) and code seatclaude-opus-5-5(poteto-agent). Agemini-*entry has no seat, so drop it. - poteto-mode panels: one runner on the judgment seat (
claude-fable-5-2) and one on the code seat (claude-opus-5-5). Agemini-*entry has no seat, so drop it. - setup-pstack step 5:
arena runners: claude-fable-5-2, claude-opus-5-5,arena cross-judge pool: claude-opus-5-5,interrogate reviewers: claude-fable-5-2, claude-opus-5-5. - README line 3 is
`0.15.46`. The panel sentence is still "the default panel is fable 5.2 / opus 5.5".
CI
Validate plugin passed on this head: https://github.com/pstack-ports/droid-pstack/actions/runs/44654711000/job/136017971449
caelaxie
left a comment
There was a problem hiding this comment.
change request (github will not accept REQUEST_CHANGES from this account because it authored the pr).
#1292's statechart copies match upstream 0b46ec399d55 verbatim. the 0.15.43 → 0.15.46 version bump is correct. skipping #1283/#1284 is consistent with the current contract: this port has no gemini seat (COMPATIBILITY.md, the two seat droids, and arena/poteto-mode/setup-pstack already drop gemini-*).
blocking: no droid harness proof. node scripts/validate-plugin.mjs, the statechart unit tests, and green "Validate plugin" ci are not enough — this pr touches plugin content (skills/statechart/). post proof from head 0d2240dbc4c19cb22e6466bbf89404fe57d9ec67:
droid plugin marketplace add <checkout or https://github.com/pstack-ports/droid-pstack>
droid plugin install pstack@droid-pstack
droid plugin list
the list needs to show the plugin and its skills loading, including deslop, control-cli, and control-ui. do not merge until that proof is on the pr.
| ``` | ||
|
|
||
| `scripts/statechart.ts` is TypeScript, so run it with a runtime that can execute TypeScript. | ||
| `scripts/statechart.ts` is TypeScript, so run it with a runtime that can execute TypeScript. `scripts/statechart` is a POSIX shell script that picks one. On native Windows, run `node --disable-warning=ExperimentalWarning <skill dir>/scripts/statechart.ts` with Node 22.18 to 22.x, or Node 23.6 or later. |
There was a problem hiding this comment.
this skill content changed, so unit tests and validate-plugin.mjs are not enough. need a real droid install of head 0d2240dbc4c19cb22e6466bbf89404fe57d9ec67 (droid plugin marketplace add + droid plugin install pstack@droid-pstack + droid plugin list) showing the plugin and skills load, including deslop, control-cli, and control-ui.
There was a problem hiding this comment.
Installed head 0d2240dbc4c19cb22e6466bbf89404fe57d9ec67 with droid plugin marketplace add of that checkout, droid plugin install pstack@droid-pstack, and droid plugin list. The list shows pstack@droid-pstack enabled at commit 0d2240dbc4c1. Installed plugin.json is 0.15.46.
droid plugin list does not print skill names. From that same install, deslop, control-cli, control-ui, and statechart each load. droid exec prints Skill "<name>" activated and then:
Error during droid execution: Authentication failed. Please log in using /login or set a valid FACTORY_API_KEY environment variable.
Full command output is in #75 (comment)
Droid install of head
|
| skill | sha256 of installed SKILL.md |
|---|---|
deslop |
2f7b7def74af7ed11f5b44b4d32f0f91fca8c5d1f92bf2171e8d12fd33a0f810 |
control-cli |
13ac93e595bbda2000849bdb815d5f2ca03f7c2ca63788c8335f9212b9b422a2 |
control-ui |
410cae25bdb1e5d2323b126abc5047b0213be7fdb0195710213fa8de8a751871 |
droid plugin list does not print skill names. Each of those skills loads from this install. droid exec activates the skill, then auth fails (FACTORY_API_KEY is unset). Verbatim stderr, exit 1, empty stdout:
Skill "deslop" activated
Error during droid execution: Authentication failed. Please log in using /login or set a valid FACTORY_API_KEY environment variable.
Skill "control-cli" activated
Error during droid execution: Authentication failed. Please log in using /login or set a valid FACTORY_API_KEY environment variable.
Skill "control-ui" activated
Error during droid execution: Authentication failed. Please log in using /login or set a valid FACTORY_API_KEY environment variable.
Skill "statechart" activated
Error during droid execution: Authentication failed. Please log in using /login or set a valid FACTORY_API_KEY environment variable.
Not merged.
caelaxie
left a comment
There was a problem hiding this comment.
pass at 0d2240d. this supersedes the earlier change-request comment #75 (review), which raced the first harness proof already on the pr.
proof is enough for the current contract. #75 (comment): marketplace add/install/list on this head, plugin enabled at 0d2240d / 0.15.46, installed hashes match the head for the changed statechart files and the unchanged arena/poteto-mode/setup-pstack text, installed statechart tests 304 pass 0 fail 70 skip (tla2tools unset; windows line-end cases passed). #75 (comment) and the reply on skills/statechart/SKILL.md: checkout-form install of pstack@droid-pstack at the same sha; droid plugin list does not print skill names; deslop, control-cli, control-ui, and statechart each activated, then droid exec auth failed (no factory_api_key). that is not a failed install and is not a full runtime claim.
#1292 copies and the 0.15.46 bump stand. skipping #1283/#1284 stays consistent with the no-gemini-seat contract. COMPATIBILITY.md and AGENTS.md are unchanged. validate plugin ci is green on this head.
Upstream
Ports pstack
0.15.46from cursor/plugins@0b46ec399d55, three commits after the last ported pin2f87c854fe3e2fcda44ca86b46ede35aad3c46b7(0.15.43).e58dd0436005chore(pstack): route the Gemini seat to Gemini 4 Neondd24b6707267chore(pstack): run the Gemini panel seat at gemini-4-neon-xhigh0b46ec399d55fix(pstack): run /statechart on native Windows and read TLC's \r\n line endsVersion is
0.15.46inplugin.json,.factory-plugin/plugin.json, and the README header. Homepage and repository stayhttps://github.com/pstack-ports/droid-pstack.What landed
skills/statechart/:SKILL.mdnames the POSIXscripts/statechartlauncher and the native Windowsnode --disable-warning=ExperimentalWarningcommand (Node 22.18 to 22.x, or Node 23.6 or later).scripts/frontends/dot.tsaddssplitLines(split on\r?\n) andlinesOfuses it.scripts/janitor.tsandscripts/kill.ts. Group kill no longer goes through/bin/sh.killGroupusestaskkill /t /fon Windows andprocess.kill(-pid, "SIGKILL")elsewhere.scripts/statechart.tsstarts the janitor with the current Node runtime, setsTEMPandTMPnext toTMPDIR, and skips killing a Windows process group after the worker has already exited (a reused pid stays up).scripts/run.tsreads file and child output withsplitLines, setswindowsHideon TLC spawns, and passes-Dstdout.encoding=UTF-8and-Dstderr.encoding=UTF-8.scripts/test/cli.test.ts,scripts/test/messages.test.ts).2f87c854before this port, so the new copies match upstream at0b46ec399d55.skills/statechart/scripts/package.jsonkeeps@droid-skill/statechart.Left alone
gemini-4-carbon-hightogemini-4-neon-xhigh, and the README panel line from "gemini 4 carbon" to "gemini 4 neon") in arena, poteto-mode, setup-pstack, the upstream README, anddocs/harness/claude-code.md. This port has no Gemini seat.skills/arena/SKILL.md,skills/poteto-mode/SKILL.md, andskills/setup-pstack/SKILL.mdalready dropgemini-*entries and were not overwritten. The README panel sentence stays "the default panel is fable 5.2 / opus 5.5". None of those files namedgemini-4-carbon-highor "gemini 4 carbon", so the Neon migration paragraph was not copied.docs/harness/claude-code.mdis not in this repo and was not added. No.cursor-plugin/directory and no.cursor/skills/paths.Checks
node scripts/validate-plugin.mjspassed.npm testinskills/statechart/scripts(node --disable-warning=ExperimentalWarning --test test/*.test.ts): 374 tests, 304 pass, 0 fail, 70 skipped (the skipped test needsTLA2TOOLS). The new Windows line-end cases passed, including the FirstRule verdict replay.