Repository navigation
Share downstream futures across timed window emitters - #504
Open
Aschenbath wants to merge 1 commit into
Open
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a timed window feeds an
async defsink, the timer callback and subsequent inputs can await the same coroutine more than once, raisingRuntimeError: cannot reuse already awaited coroutine. Convert each window's downstream results to a shared Future once, so concurrent and later inputs wait for the same work. Apply the same fix totimed_window_unique.Fixes #284.
Nine regression/control cases cover both window types, both unique retention modes, native coroutines, Tasks, Tornado Futures, concurrent producers, completed work, two successive windows and a synchronous sink branch. On the original source, the three native-coroutine cases fail; all nine pass with the change on Windows CPython 3.10.22 and 3.12.15. Independent agent review passed 240 assertions, including exception propagation and synchronous callers using a background event loop. Flake8, wheel/sdist builds and installed-wheel checks pass.
The full suite is not green on this Windows host. The complete core module reports 130 passed / 4 failed with the patch; unchanged source reports 120 passed / 5 failed. All four patched failure cases also fail on the unchanged source across the baseline runs, involving existing timing/order assertions. Full-project runs on both versions reach 99% before the same
test_process_strstalls and the 30-second watchdog stops execution. Other platforms and the upstream CI matrix were not run locally.AI disclosure: prepared and tested with OpenAI Codex under the account owner's authorization, with independent review by a separate coding agent. No human review is claimed.