Skip to content

gh-161242: Use AC vectorcall for AttributeError, ImportError, NameError #161462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmaloney wants to merge 4 commits into
base: main
Choose a base branch
from
+389 −55
Open

gh-161242: Use AC vectorcall for AttributeError, ImportError, NameError #161462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a50593d
gh-161242: Use AC vectorcall for AttributeError, ImportError, NameError
cmaloney Nov 3, 2026
adce6d0
Update test_call for the new ImportError keyword error message
cmaloney Nov 6, 2026
d73995e
Add NEWS
cmaloney Nov 7, 2026
16aa18f
Add missing newline
cmaloney Nov 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/test/test_call.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ def test_varargs14_kw(self):
itertools.product, 0, repeat=1, foo=2)

def test_varargs15_kw(self):
msg = r"^ImportError\(\) takes at most 3 keyword arguments \(4 given\)$"
msg = r"^ImportError\(\) got an unexpected keyword argument 'foo'$"

@eendebakpt eendebakpt Nov 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a news entry for the change in the error message

@cmaloney cmaloney Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a NEWS for the speedup, vectorcall support, and error string change.

self.assertRaisesRegex(TypeError, msg,
ImportError, 0, name=1, path=2, name_from=3, foo=3)

Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-11-06-21-21-04.gh-issue-161242.d4vNgC.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Speed up :exc:`AttributeError`, :exc:`ImportError` and
:exc:`NameError` by enabling :ref:`vectorcall`. Unexpected
keyword arguments are now reported by name.
329 changes: 328 additions & 1 deletion Objects/clinic/exceptions.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading