Repository navigation
Conversation
itamaro
added
build
configure sets _PYTHON_HOST_PLATFORM only for cross builds, but passed it to the build Python for every --with-build-python build. In a native build it was empty, so sysconfig.get_platform() returned "" and build-details.json ended up with "platform": "". Co-authored-by: Zanie Blue <[email protected]> Co-Authored-By: Claude Fable 5.1 <[email protected]>
itamaro
force-pushed
the
gh-140266-host-platform-cross-only
branch
from
November 7, 2026 05:03
4321c38 to
c7bf53b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configureonly sets_PYTHON_HOST_PLATFORMwhen cross compiling, butPYTHON_FOR_BUILDexported it whenever--with-build-pythonwas given. A native build with a build Python got_PYTHON_HOST_PLATFORM="", whichsysconfig.get_platform()returns unchanged, sobuild-details.jsonhad"platform": ""and the build directory was namedbuild/lib.-3.X.This passes the variable only when cross compiling.
Tested on macOS with
./configure --with-build-python=... && make build-details.json:platformismacosx-27.2-arm64and the build directory is named normally.Written with assistance from Claude Fable 5.1