Repository navigation
gh-162034: Quote paths in the Apple testbed's utils.sh - #162161
Conversation
install_python left several paths unquoted. A space in a package path
or in the XCframework path split it, so modules were left unconverted
or the build failed. Brackets in the build path broke the prefix strip,
so all modules went into one misnamed framework. read without -r dropped
a backslash from the build path, so mv failed.
Quote these paths and the variables used as patterns in ${...}, and
use read -r.
|
Thanks @fametrano for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
Sorry, @fametrano and @freakboy3742, I could not cleanly backport this to Please backport manually with cherry_picker, see the devguide for more information. |
|
Sorry, @fametrano and @freakboy3742, I could not cleanly backport this to Please backport manually with cherry_picker, see the devguide for more information. |
|
GH-162180 is a backport of this pull request to the 3.15 branch. |
|
GH-162181 is a backport of this pull request to the 3.14 branch. |
) (#162181) Add additional protection against spaces and other special characters in iOS Xcode build scripts. (cherry picked from commit 3ad9316) Co-authored-by: Ferdinando Ametrano <[email protected]>
) (#162180) Add additional protection against spaces and other special characters in iOS Xcode build scripts. (cherry picked from commit 3ad9316) Co-authored-by: Ferdinando Ametrano <[email protected]>
|
|
|
The Android failures were probably caused by running out of disk space again – #161829 (comment). |
|
Quoting paths and using
read -rfix how the Apple testbed converts extension modules when a path holds a space, brackets or a backslash. A space in a package or XCframework path left modules unconverted or failed the build. Brackets in the build path put all modules in one misnamed framework. A backslash there mademvfail.On this branch, every case of the script from #162034 exits 0, with each module in its own framework.