Repository navigation
Conversation
u64 is an unsigned 64-bit integer. The implementation mostly follows u16 (#22368). Major differences: - Boxing uses PyLong_FromUnsignedLongLong. - A u64 may not fit in a short tagged int, so converting to int checks the range and calls CPyTagged_FromUInt64 for large values. Converting from int accepts any non-negative short int directly and uses CPyLong_AsUInt64 for long ints. - Add list get/set item primitives that take a u64 index. Work on mypyc/mypyc#1226.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
p-sawicki
approved these changes
Nov 6, 2026
Comment on lines
+69
to
+71
| a: u64 = 18446744073709551616 | ||
| b: u64 = -1 | ||
| f(18446744073709551616) |
Collaborator
There was a problem hiding this comment.
i think we're missing an error for the 2^64 literals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
u64 is an unsigned 64-bit integer. The implementation mostly follows u16 (#22368).
Major differences:
Work on mypyc/mypyc#1226.