Repository navigation
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/25323
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 45 Pending, 1 Unrelated FailureAs of commit f7cff09 with merge base 21c7c99 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@claude /pr-review |
|
Claude finished @Gasoonjia's task in 11m 58s —— View job PR Review: #25323Needs discussion: the move deletes Detailed reviewSummaryThe PR moves
Code Quality
Infrastructure
Testing
Backward Compatibility
RecommendationNeeds Discussion: if
Three independent reviewers covered all five changed files, and I re-read the cited code for each finding above. I couldn't check release tags or run Buck from this job. I didn't run the test suites either; the merge suite needs |
5d70aa6 to
1bf9426
Compare
|
@claude addressed, with one deliberate exception:
Kept as-is, deliberately: retiring |
|
@claude /pr-review |
|
Claude finished @Gasoonjia's task in 40s —— View job Follow-up review: #25323All three fixes are on the branch and do what you described. I'm not raising the deprecation shim again, since you've made that call. Nothing blocking is left from my side. DetailsFixes I checked
Deprecation shimI accept your decision to remove the old module path without a shim. Every in-repo caller is updated, and I couldn't confirm the old path ever shipped in a release. Optional notes
VerificationI read the code and the diff against
|
|
Claude finished @Gasoonjia's task in 16m 24s —— View job PR Review: #25323Approve: nothing blocks, though the merged PTE is still replaced before the PTD copy starts, this round's PTD and argument-check changes have no tests, and the removal isn't labeled Detailed reviewSummaryThe PR moves Code Quality
Testing
Backward Compatibility
RecommendationApprove: nothing blocks. The reorder and the tests are small enough to land in this PR. The label only matters if the old path was in a release.
Three independent reviewers covered all five changed files, and I re-read the cited code for each finding. I couldn't run Python or Buck in this job, so no tests were run (the merge suite also needs |
a730120 to
7eb0f3b
Compare
1bf9426 to
eb2e169
Compare
|
@claude /pr-review |
|
Claude finished @Gasoonjia's task in 17m 0s —— View job PR Review: #25323Approve: nothing blocks merging. The details list five minor items, mainly two behavior changes with no test (the PTD's new mode and the earlier Detailed reviewSummaryThe PR moves
Code Quality
Testing
Backward Compatibility
RecommendationApprove: nothing blocks merging. The two tests and the label are quick to add in this PR; the write order and the comment are optional.
Three independent reviewers covered all five changed files, and I re-read the cited code for every finding. I did not run |
|
Claude finished @Gasoonjia's task in 17m 25s —— View job PR Review: #25323Approve: nothing blocks, but the commit message still names a Detailed reviewSummaryThe PR moves Except for the remap test count, everything below was raised in the 01:26 review and is still on the branch. The 01:38 follow-up only re-checked the two cleanups, so it didn't carry these forward. Code Quality
Testing
Performance
RecommendationApprove: nothing blocks.
Three independent reviewers covered all six changed files, and I re-read the cited code for each finding. No tests ran: I couldn't run Python or Buck in this job, and the merge suite also needs |
a006110 to
896b9e6
Compare
c52fa38 to
7d43a53
Compare
|
Restacked on the updated #25315 (atomic-writer nit fixes only; no change to the move). |
|
@claude /pr-review |
|
Claude finished @Gasoonjia's task in 19m 55s —— View job PR Review: #25323Approve: nothing blocks, but a failed PTE write now leaves the new PTD next to the old PTE, two of the new tests can pass without checking what they're named for, and the commit message and description still make a few claims that don't match the change. Detailed reviewSummaryThe PR moves Code Quality
Testing
Performance
RecommendationApprove: nothing blocks. The two test fixes, the copy change and the text edits are small enough to land in this PR. The two-phase write is optional.
Three independent reviewers covered all six changed files, and I re-read the cited code for every finding. I left out three reviewer findings:
Python, |
7d43a53 to
202a8f7
Compare
|
@claude addressed the small items from this round as well, except the optional two-phase write:
Two-phase staging of both outputs stays out, as you flagged it optional: it needs a two-phase form of the base PR's writer, and PTD-first already ensures the likelier failure (the large copy) cannot orphan a new PTE. |
|
@claude /pr-review |
|
Claude finished @Gasoonjia's task in 15m 38s —— View job PR Review: #25323Approve: nothing blocks, but the advertised Detailed reviewSummaryThe PR moves Code Quality
Testing
RecommendationApprove: nothing blocks. The test and the description edit are small.
Three independent reviewers covered all six changed files, and I re-read the cited code for each finding. I dropped two reviewer suggestions:
No tests ran: I couldn't run Python, |
|
Claude finished @Gasoonjia's task in 44s —— View job Follow-up review: #25323Approve: all three items are on the branch and work as you describe, and nothing blocks merging; one optional nit is left in the details. DetailsWhat I checked
Optional nit
Two-phase writeI accept leaving it out. PTD-first covers the likelier failure, the large copy. VerificationThis was a targeted re-check of the items you addressed, not a full three-reviewer pass. I read the diff against
|
896b9e6 to
fcf50da
Compare
Stacked on the remap_pte_devices PR, which starts the scripts directory. merge_ptes is the other standalone CUDA backend tool, so it belongs there too: backends/cuda/merge_ptes.py moves to backends/cuda/scripts/merge_ptes.py. The CUDA CI workflow, the CUDA examples README, its tests, and the :merge_ptes Buck target now use executorch.backends.cuda.scripts.merge_ptes. The old module path is retired outright; the release-notes: devtools label covers the move. While moving, both outputs write through the shared atomic writer from the base PR's :scripts_atomic_output library. The PTD is copied first with FileBackedData, so a failed copy leaves the existing output PTE untouched. Both outputs keep their inputs' permissions and remove their temp files when a write fails, instead of leaving 0600 or truncated files behind. The --output-ptd argument check now runs before any output is written. Three overlong lines in the moved file are wrapped as part of the move. Test Plan: - backends/cuda/tests/test_merge_ptes.py (now also registered as a Buck python_unittest): import strings point at the new module path, the CLI test checks PTE and PTD output permissions against distinctive input modes, --output-ptd without --input-ptd is rejected before the merge runs, and a failed PTD copy leaves prior outputs unchanged with no temp files. The suite needs flatc, which this environment lacks, and runs in CI; the missing-input argument test passes locally. - backends/cuda/tests/test_remap_pte_devices.py still passes (22 tests) on this stack.
|
Restacked onto current |
|
@claude /pr-review |
|
Claude finished @Gasoonjia's task in 13m 22s —— View job PR Review: #25323Approve: nothing blocks, but one new test's name says the opposite of what it checks, the PR description and commit message are out of date in a few places, and the Detailed reviewSummaryThe PR moves Code Quality
Testing
RecommendationApprove: nothing blocks. The rename and the text edits are quick, and the symlink test is small.
Three independent reviewers covered all six changed files, and I re-read the cited code for every finding. I left out three reviewer findings:
No tests were run: the merge suite needs |
Stacked on #25315 — review/merge that first; this PR's diff is against its branch.
What
Moves the other standalone CUDA backend tool into the
scripts/package #25315 starts:backends/cuda/merge_ptes.py→backends/cuda/scripts/merge_ptes.py, shown by Git as a rename. Every reference — the CUDA CI workflow's merge step, the documented command inexamples/cuda/README.md, the imports and patch targets intest_merge_ptes.py(now also registered as a Buckpython_unittest), and the:merge_ptesBuck target — now usesexecutorch.backends.cuda.scripts.merge_ptes.The old module path is retired outright, with no forwarding shim — a deliberate maintainer call for this move: merge_ptes is a standalone, one-shot tool (run it once to produce a file), not a library surface other code builds on, every in-repo caller is updated here, and keeping a forwarding module at the old path would defeat the move (the PR stops reading as a rename, and the old path lingers as a second home for the tool). The
release notes: devtoolslabel calls the path change out (the repo has nobreaking-changelabel to add, though release.yml reserves a category for one).The content changes in the moved file are the output-writing changes below plus three wrapped overlong lines. Both outputs write through the shared
scripts/_atomic_outputwriter from the base PR's:scripts_atomic_outputlibrary. The PTD is copied first withFileBackedData(8 MiB chunks, as fast as the oldshutil.copyfilepath), so a failed copy leaves the existing output PTE untouched instead of pairing a new PTE with a stale weights blob. Both outputs keep their inputs' permissions and remove their temp files when a write fails, instead of leaving 0600 or truncated files behind; an existing--output-ptdsymlink is now replaced by a regular file rather than written through. The--output-ptd requires --input-ptdcheck now runs with the other argument checks, before any output is written.Tests
test_merge_ptes.pyimport strings point at the new path; the CLI test now also asserts the merged PTE and PTD keep distinctive input modes (0o640/0o604) with no temp files left,--output-ptdwithout--input-ptdis rejected before the merge runs and writes nothing, and a failed PTD copy (patchedFileBackedData) leaves pre-existing outputs byte-identical — the last also covers the PTD-first ordering. The suite needsflatc, unavailable in my local environment, and runs in CI (now also as a Buckpython_unittest); the argument-check test passes locally. The 22test_remap_pte_devices.pytests still pass on this stack.