Skip to content

Only require DT for HTML coverage reports with covr < 4.0.0 - #2712

Merged
jennybc merged 4 commits into
mainfrom
report-dt-covr4
Nov 18, 2026
Merged

jennybc merged 4 commits into
mainfrom
report-dt-covr4

Conversation

@jimhester

Copy link
Copy Markdown
Member

covr 4.0.0, now on CRAN, builds its HTML reports without DT, jQuery or Bootstrap (r-lib/covr#709), so show_report() doesn't need to check that DT is installed. The check is kept for older versions of covr, whose reports still need it.

Checked with covr 4.0.0: test_coverage_active_file(report = "html") only calls check_installed() for covr.

@jennybc jennybc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I know it doesn't really have teeth in Suggests but let's bump the version of covr here too:

covr (>= 3.5.1),

@jennybc
jennybc merged commit e60c018 into main Nov 18, 2026
13 checks passed
@jennybc
jennybc deleted the report-dt-covr4 branch November 18, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants