Repository navigation
fix: support closable.disabled for close button #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
feritcemkahraman
wants to merge
1
commit into
react-component:master
Choose a base branch
from
feritcemkahraman:fix/closable-disabled-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: react-component/notification
Length of output: 4584
🏁 Script executed:
Repository: react-component/notification
Length of output: 6626
🏁 Script executed:
Repository: react-component/notification
Length of output: 7301
🌐 Web query:
React 19 disabled button programmatic dispatchEvent click onClick ancestor bubbling official source💡 Result:
🌐 Web query:
site:github.com/facebook/react v19.2.7 react-dom-bindings getListener.js shouldPreventMouseEvent disabled onClick💡 Result:
在通知根节点拦截禁用关闭按钮的冒泡事件。
原评论中的事件链不准确。React 19 不会调用
disabled<button>的onClick,因此onInternalCloseClick不会处理这个程序化事件。但是,可冒泡的dispatchEvent()仍可能触发通知根节点的onClick。因此,将
stopPropagation()移到onInternalCloseClick的禁用分支之前不能修复问题。请在通知根节点的捕获阶段,针对禁用关闭按钮的事件调用preventDefault()和stopPropagation(),并增加对应的程序化事件测试。建议修改
🤖 Prompt for AI Agents