Repository navigation
test(e2e): don't snapshot react-native's command descriptions and order - #2894
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__e2e__/config.test.tsfails onmain(e.g. https://github.com/react-native-community/cli/actions/runs/43202706151): theconfigoutput snapshot includes commands registered byreact-nativeitself (bundle,start,codegen,spm [action]). React Native 0.88.1 changed thespmdescription (addedsync) and the order those commands are registered in, so the snapshot breaks on a React Native patch release, with no CLI change.The test now replaces command descriptions with
<<REPLACED>>, the same as it already does foroptionsandexamples, and sorts commands by name. The snapshot still catches a command being added or removed, or gaining or losing options or examples.Test Plan
CI (E2E Tests). The snapshot was updated by applying the same transform to the existing one; it contains the same commands.