Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@zeyap has exported this pull request. If you are a Meta employee, you can view the originating Diff in D129170428. |
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Nov 6, 2026
Summary: Pull Request resolved: react#59771 **Problem**: `EventEmitterListener.h` moved to `react/renderer/core`; `react/renderer/animated/EventEmitterListener.h` only forwards to it. **Proposed change**: Remove the forwarding header and include `react/renderer/core/EventEmitterListener.h` directly. **Changes**: - C++: delete `react/renderer/animated/EventEmitterListener.h` and drop it from the `animated` target's exported headers. - Internal includers (Granite, ViewEvent, React Native Windows): include the `core` header. Code that includes `<react/renderer/animated/EventEmitterListener.h>` must include `<react/renderer/core/EventEmitterListener.h>` instead. Changelog: [General][Breaking] - Remove `react/renderer/animated/EventEmitterListener.h`; include `react/renderer/core/EventEmitterListener.h` instead Reviewed By: fkgozali Differential Revision: D129170428
zeyap
force-pushed
the
export-D129170428
branch
from
November 6, 2026 18:10
ef8dba0 to
d872f6a
Compare
meta-codesync
Bot
changed the title
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Nov 6, 2026
Summary: Pull Request resolved: react#59771 **Problem**: `EventEmitterListener.h` moved to `react/renderer/core`; `react/renderer/animated/EventEmitterListener.h` only forwards to it. **Proposed change**: Remove the forwarding header and include `react/renderer/core/EventEmitterListener.h` directly. **Changes**: - C++: delete `react/renderer/animated/EventEmitterListener.h` and drop it from the `animated` target's exported headers. - Internal includers (Granite, ViewEvent, React Native Windows): include the `core` header. Code that includes `<react/renderer/animated/EventEmitterListener.h>` must include `<react/renderer/core/EventEmitterListener.h>` instead. Changelog: [General][Changed] - Remove `react/renderer/animated/EventEmitterListener.h`; include `react/renderer/core/EventEmitterListener.h` instead Reviewed By: fkgozali Differential Revision: D129170428
zeyap
force-pushed
the
export-D129170428
branch
from
November 6, 2026 19:14
d872f6a to
c0b7ff9
Compare
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Nov 6, 2026
Summary: **Problem**: `EventEmitterListener.h` moved to `react/renderer/core`; `react/renderer/animated/EventEmitterListener.h` only forwards to it. **Proposed change**: Remove the forwarding header and include `react/renderer/core/EventEmitterListener.h` directly. **Changes**: - C++: delete `react/renderer/animated/EventEmitterListener.h` and drop it from the `animated` target's exported headers. - Internal includers (Granite, ViewEvent, React Native Windows): include the `core` header. Code that includes `<react/renderer/animated/EventEmitterListener.h>` must include `<react/renderer/core/EventEmitterListener.h>` instead. Changelog: [General][Removed] - Remove `react/renderer/animated/EventEmitterListener.h`; include `react/renderer/core/EventEmitterListener.h` instead Reviewed By: fkgozali Differential Revision: D129170428
zeyap
force-pushed
the
export-D129170428
branch
from
November 6, 2026 21:53
c0b7ff9 to
1319036
Compare
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Nov 6, 2026
Summary: **Problem**: `EventEmitterListener.h` moved to `react/renderer/core`; `react/renderer/animated/EventEmitterListener.h` only forwards to it. **Proposed change**: Remove the forwarding header and include `react/renderer/core/EventEmitterListener.h` directly. **Changes**: - C++: delete `react/renderer/animated/EventEmitterListener.h` and drop it from the `animated` target's exported headers. - Internal includers (Granite, ViewEvent, React Native Windows): include the `core` header. Code that includes `<react/renderer/animated/EventEmitterListener.h>` must include `<react/renderer/core/EventEmitterListener.h>` instead. Changelog: [General][Removed] - Remove `react/renderer/animated/EventEmitterListener.h`; include `react/renderer/core/EventEmitterListener.h` instead Reviewed By: fkgozali Differential Revision: D129170428
zeyap
force-pushed
the
export-D129170428
branch
from
November 6, 2026 21:57
1319036 to
49285a6
Compare
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Nov 6, 2026
Summary: **Problem**: `EventEmitterListener.h` moved to `react/renderer/core`; `react/renderer/animated/EventEmitterListener.h` only forwards to it. **Proposed change**: Remove the forwarding header and include `react/renderer/core/EventEmitterListener.h` directly. **Changes**: - C++: delete `react/renderer/animated/EventEmitterListener.h` and drop it from the `animated` target's exported headers. - Internal includers (Granite, ViewEvent, React Native Windows): include the `core` header. Code that includes `<react/renderer/animated/EventEmitterListener.h>` must include `<react/renderer/core/EventEmitterListener.h>` instead. Changelog: [General][Removed] - Remove `react/renderer/animated/EventEmitterListener.h`; include `react/renderer/core/EventEmitterListener.h` instead Reviewed By: fkgozali Differential Revision: D129170428
zeyap
force-pushed
the
export-D129170428
branch
from
November 6, 2026 21:57
49285a6 to
72a7a7f
Compare
Summary: Pull Request resolved: react#59771 **Problem**: `EventEmitterListener.h` moved to `react/renderer/core`; `react/renderer/animated/EventEmitterListener.h` only forwards to it. **Proposed change**: Remove the forwarding header and include `react/renderer/core/EventEmitterListener.h` directly. **Changes**: - C++: delete `react/renderer/animated/EventEmitterListener.h` and drop it from the `animated` target's exported headers. - Internal includers (Granite, ViewEvent, React Native Windows): include the `core` header. Code that includes `<react/renderer/animated/EventEmitterListener.h>` must include `<react/renderer/core/EventEmitterListener.h>` instead. Changelog: [General][Removed] - Remove `react/renderer/animated/EventEmitterListener.h`; include `react/renderer/core/EventEmitterListener.h` instead Reviewed By: fkgozali Differential Revision: D129170428
zeyap
force-pushed
the
export-D129170428
branch
from
November 6, 2026 22:02
72a7a7f to
a8b620f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Problem:
EventEmitterListener.hmoved toreact/renderer/core;react/renderer/animated/EventEmitterListener.honly forwards to it.Proposed change: Remove the forwarding header and include
react/renderer/core/EventEmitterListener.hdirectly.Changes:
react/renderer/animated/EventEmitterListener.hand drop it from theanimatedtarget's exported headers.coreheader.Code that includes
<react/renderer/animated/EventEmitterListener.h>must include<react/renderer/core/EventEmitterListener.h>instead.Changelog:
[General][Removed] - Remove
react/renderer/animated/EventEmitterListener.h; includereact/renderer/core/EventEmitterListener.hinsteadReviewed By: fkgozali
Differential Revision: D129170428