Repository navigation
Conversation
Signed-off-by: hunter <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4292, specifically the case where macOS marks the process as unresponsive while Java language requests still succeed.
What changes
Pass Equinox's
-nosplashlauncher argument on macOS for both the standard and syntax servers. Even when no splash window is configured, Equinox's startup monitor can still invokeupdateSplash(). On macOS that calls the native event dispatcher, which calls[NSApplication sharedApplication]and registers a WindowServer connection for JDT LS.-nosplashskips that update path.In the affected session, WindowServer reported
connectionIsUnresponsive: 1for the original process. The same PID still handled a new Java validation request in VS Code.Verification
-nosplashadded, neither mode registered a connection during the observation window.initializeandtextDocument/documentSymbolpassed for all four test launches. The standard mode used the Unix socket transport and syntax mode used stdio.-Djava.awt.headless=truealone still produced a WindowServer connection in a separate control.git diff --checkpassed.-nosplash.