Skip to content

Fix dead MavenCompletionParticipant links in extension docs - #1193

Merged
angelozerr merged 1 commit into
redhat-developer:mainfrom
farisbasha:docs-fix-lemminx-maven-links
Nov 18, 2026
Merged

angelozerr merged 1 commit into
redhat-developer:mainfrom
farisbasha:docs-fix-lemminx-maven-links

Conversation

@farisbasha

Copy link
Copy Markdown
Contributor

docs/Extensions.md links to MavenCompletionParticipant.java twice (the completion participant example and the vscode-xml-maven sample). Both links point to eclipse/lemminx-maven/.../extensions/maven/MavenCompletionParticipant.java#L75 / #L210, which return 404: the class moved to extensions/maven/participants/completion/MavenCompletionParticipant.java, and the repository is now eclipse-lemminx/lemminx-maven.

Both links now point to https://github.com/eclipse-lemminx/lemminx-maven/blob/master/lemminx-maven/src/main/java/org/eclipse/lemminx/extensions/maven/participants/completion/MavenCompletionParticipant.java (200, no redirect). I dropped the #L75 / #L210 line anchors because those line numbers no longer match the moved file.

Docs-only change; commit is signed off (DCO).

lemminx-maven moved MavenCompletionParticipant.java into the
participants/completion package, so both links return 404. Point them
at the current file in eclipse-lemminx/lemminx-maven.

Signed-off-by: farisbasha <[email protected]>
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Documentation
    • Updated the custom completion participant guide’s Maven sample links.

The Maven completion participant documentation now links to the current eclipse-lemminx/lemminx-maven repository path. The participant source and example links no longer include line anchors.

Changes: Maven completion documentation

Layer / File(s) Summary
Update Maven completion links
docs/Extensions.md
The participant source link uses the updated repository path. Both links omit their previous line anchors.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: datho7561

Merge Risk: Minimal · up to 68934

This docs-only change fixes broken links to the Maven completion participant. It has no runtime impact and is safe to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title states the main change: fixing dead MavenCompletionParticipant links in the extension docs. The changeset updates both MavenCompletionParticipant.java links in docs/Extensions.md to the move…
Description check Passed The description explains the problem (two links returning 404 after the class moved), the new URL, the removal of the line anchors, and the docs-only scope. It matches the changeset in docs/Extensions…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title states the main change: fixing dead MavenCompletionParticipant links in the extension docs. The changeset updates both MavenCompletionParticipant.java links in docs/Extensions.md to the moved file location, which matches the title.

Full details: Description check

Explanation

The description explains the problem (two links returning 404 after the class moved), the new URL, the removal of the line anchors, and the docs-only scope. It matches the changeset in docs/Extensions.md.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b4f13e49-8f34-4c41-88f5-63b1b5082bf7
Commits

Reviewing files that changed from the base of the PR and between aa31b72 and 6893400.

Files selected for processing: 1

  • docs/Extensions.md

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@angelozerr angelozerr added bug Something isn't working documentation labels Nov 18, 2026
@angelozerr angelozerr added this to the 0.30.0 milestone Nov 18, 2026
@angelozerr
angelozerr self-requested a review November 18, 2026 09:42
@angelozerr angelozerr moved this to In Progress in Java Tooling Nov 18, 2026
@angelozerr

Copy link
Copy Markdown
Contributor

LGTM, thanks @farisbasha !

@angelozerr
angelozerr merged commit fcb304f into redhat-developer:main Nov 18, 2026
7 of 12 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Java Tooling Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants