Repository navigation
Fix dead MavenCompletionParticipant links in extension docs - #1193
Merged
angelozerr merged 1 commit intoNov 18, 2026
Merged
Conversation
lemminx-maven moved MavenCompletionParticipant.java into the participants/completion package, so both links return 404. Point them at the current file in eclipse-lemminx/lemminx-maven. Signed-off-by: farisbasha <[email protected]>
Contributor
|
LGTM, thanks @farisbasha ! |
angelozerr
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/Extensions.mdlinks toMavenCompletionParticipant.javatwice (the completion participant example and the vscode-xml-maven sample). Both links point toeclipse/lemminx-maven/.../extensions/maven/MavenCompletionParticipant.java#L75/#L210, which return 404: the class moved toextensions/maven/participants/completion/MavenCompletionParticipant.java, and the repository is noweclipse-lemminx/lemminx-maven.Both links now point to https://github.com/eclipse-lemminx/lemminx-maven/blob/master/lemminx-maven/src/main/java/org/eclipse/lemminx/extensions/maven/participants/completion/MavenCompletionParticipant.java (200, no redirect). I dropped the
#L75/#L210line anchors because those line numbers no longer match the moved file.Docs-only change; commit is signed off (DCO).