Skip to content

Bump GraalVM distro to Java 25 in order to get build working - #1197

Merged
angelozerr merged 1 commit into
redhat-developer:mainfrom
datho7561:fix-build
Nov 19, 2026
Merged

angelozerr merged 1 commit into
redhat-developer:mainfrom
datho7561:fix-build

Conversation

@datho7561

Copy link
Copy Markdown
Contributor

lemminx still only requires Java 11, but the version of the GraalVM maven plugin that's used requires a Java 25 GraalVM.

lemminx still only requires Java 11, but the version
of the GraalVM maven plugin that's used requires a
Java 25 GraalVM.

Signed-off-by: David Thompson <[email protected]>
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Chores
    • Updated native-image builds and smoke tests on Unix and Windows to use GraalVM Java 25 instead of Java 17.
    • Other build and artifact steps remain unchanged.

The native-image and smoke-test workflows now configure GraalVM with Java 25 instead of Java 17. The native-image workflow updates both Unix and Windows jobs.

Changes: GraalVM Java Version Update

Layer / File(s) Summary
Update workflow Java versions
.github/workflows/native-image.yaml, .github/workflows/smoke-test.yaml, .github/workflows/smoke-test-windows.yaml
The native-image workflow’s Unix and Windows jobs and both smoke-test workflows now select Java 25 instead of Java 17.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: rgrunber

Merge Risk: Minimal · up to 3b01d

This updates the CI workflows to build native images with Java 25 GraalVM. No concrete defect was found. The only open question is whether the pinned LemMinX release compiles under Java 25, which the first native-image run would reveal.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title states the main change: the GraalVM distribution is bumped to Java 25 so the build works. The raw summary confirms the workflow files switch from Java 17 to Java 25 for GraalVM setup, so the…
Description check Passed The description explains the reason for the change. Lemminx still requires Java 11, but the GraalVM Maven plugin version in use requires a Java 25 GraalVM. This relates directly to the workflow versio…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title states the main change: the GraalVM distribution is bumped to Java 25 so the build works. The raw summary confirms the workflow files switch from Java 17 to Java 25 for GraalVM setup, so the title matches the changeset.

Full details: Description check

Explanation

The description explains the reason for the change. Lemminx still requires Java 11, but the GraalVM Maven plugin version in use requires a Java 25 GraalVM. This relates directly to the workflow version bumps.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cb436ed7-413e-41f6-91e9-5f40ff9a42c4
Commits

Reviewing files that changed from the base of the PR and between 0e5136a and 3b01d86.

Files selected for processing: 3

  • .github/workflows/native-image.yaml
  • .github/workflows/smoke-test-windows.yaml
  • .github/workflows/smoke-test.yaml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@angelozerr
angelozerr self-requested a review November 19, 2026 17:20
@angelozerr angelozerr added this to the 0.30.0 milestone Nov 19, 2026
@angelozerr angelozerr moved this to In Progress in Java Tooling Nov 19, 2026
@angelozerr

Copy link
Copy Markdown
Contributor

LGTM, thanks @datho7561 !

@angelozerr
angelozerr merged commit 19ac17f into redhat-developer:main Nov 19, 2026
12 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Java Tooling Nov 19, 2026
@datho7561
datho7561 deleted the fix-build branch November 19, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants