Skip to content

DeprecationWarning with pytest #252

Closed

Description

@metal3d

Describe the bug
Running tests for one project, I see:

../../.local/share/virtualenvs/rethinkmodel-WGhjQTXi/lib/python3.9/site-packages/rethinkdb/ast.py:87
  /home/metal3d/.local/share/virtualenvs/rethinkmodel-WGhjQTXi/lib/python3.9/site-packages/rethinkdb/ast.py:87: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working
    elif isinstance(val, collections.Callable):

../../.local/share/virtualenvs/rethinkmodel-WGhjQTXi/lib/python3.9/site-packages/rethinkdb/ast.py:108
  /home/metal3d/.local/share/virtualenvs/rethinkmodel-WGhjQTXi/lib/python3.9/site-packages/rethinkdb/ast.py:108: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working
    elif isinstance(val, collections.Mapping):

rethinkmodel/tests/test_generic.py::GenericTest::test_create
  /home/metal3d/.local/share/virtualenvs/rethinkmodel-WGhjQTXi/lib/python3.9/site-packages/rethinkdb/ast.py:115: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working
    elif isinstance(val, collections.Iterable):

Note the message: with Python 3.10, the module will stop working. I made a Pull Request to fix, see #253

To Reproduce
Steps to reproduce the behavior:

  1. Launch pytest on any project using rethinkdb

Expected behavior
No warning...

System info

  • OS: Linux Fedora 33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingnot qualifiedThe issue is not checked yet by the owners

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions