Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PHP tests can now run on multisite inside the wp-env test environment, and repeat test runs reuse an environment that is already up.
Technical Details
npm run test:php:multisiteruns the PHPUnit suite withWP_MULTISITE=1in the wp-env test environment, which closes the "Multisite tests" known gap.composer test-multisitenow usesvendor/bin/phpunit -c phpunit.xml.dist, likecomposer test.pretest:phpskipswp-env startonly whenwp core is-installedsucceeds, so a stopped or still-starting database still gets started. This check moved here from fix(init): unlink example taxonomies when post-types is removed #82, whosecli truecheck passed with the database down.pretest:phprunscomposer installwhencomposer.lockis newer thanvendor/autoload.php, then touches that file. Composer leaves unchanged autoload files untouched, so without the touch every run after a lockfile change would reinstall..wp-env.tests.jsonno longer downloads Twenty Twenty-Two; no test uses a theme..wp-env.tests.json, since a running environment is reused as it is.Checklist
npm run test:phpfrom a stopped env starts it and passes (118 tests); a second run reuses it (12 s → 5 s).npm run test:php:multisiteprints "Running as multisite" and passes, from a stopped and a running env.touch composer.lock, the next run installs and the run after that skips.composer validateandnpm run lint:package-jsonpass.