Repository navigation
Fix the dead global thread pool API link in thread_pools.md - #1123
Merged
bensheldon merged 1 commit intoNov 17, 2026
Merged
Conversation
There is no Concurrent::Configuration page in the API docs (it 404s, also under master/). The global executors (global_io_executor, global_fast_executor, ...) are documented on the Concurrent module page, so link that instead.
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Global Thread Pools" paragraph in
docs-source/thread_pools.mdlinks the API documentation athttp://ruby-concurrency.github.io/concurrent-ruby/Concurrent/Configuration.html, which returns 404 (so does the same page undermaster/).The global executors (
Concurrent.global_io_executor,global_fast_executor,global_immediate_executor) are documented on theConcurrentmodule page, so the link now points tohttps://ruby-concurrency.github.io/concurrent-ruby/master/Concurrent.html(200, no redirect), the same page this file already links forConcurrent.processor_count.Docs-only, one line. Found with the help of an AI assistant; the old and new links were checked with
curl -sI.