Repository navigation
Pass the message through in Channel::ValidationError - #1124
Open
costajohnt wants to merge 1 commit into
Open
costajohnt wants to merge 1 commit into
costajohnt wants to merge 1 commit into
Conversation
initialize set a default message but never called super, so the message was always the class name.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concurrent::Channel::ValidationError#initializesets a default message but never callssuper, so the message is always the class name:As a result
Channel#put!(nil)andChannel#offer!(nil)lose their "nil is not a valid value" message, and a failed validator gives the class name instead of "invalid value".Fix: call
super(message), the same asConcurrent::Agent::ValidationErroralready does.Test: the
put!specs for "rejects when the validator returns false" and "rejects nil" in spec/concurrent/channel_spec.rb now check the message as well as the class. Both fail on master and pass with this change.Found with rbcop, RuboCop reimplemented in Rust.