Repository navigation
Move the profiles controller spec into the profile system spec - #1295
Merged
Merged
Conversation
The only behaviour left in it was the incomplete-profile warning on the profile edit page. That now runs through the page with the shared example introduced in the proposals conversion, plus the no-warning case for a complete profile. The controller-level shared example had no other users and goes with the controller spec. Co-Authored-By: Claude Fable 5.1 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second per-file conversion.
spec/controllers/profiles_controller_spec.rbis deleted; the only behaviour left in it was the incomplete-profile warning on the profile edit page.spec/system/profile_spec.rbnow checks that warning through the page with thean incomplete profile warningshared example from #1294 (six cases), plus the no-warning case for a complete profile.The old controller-level shared example
an incomplete profile notifierhad no other users left and is removed too.Test
Full suite locally: 695 examples, 0 failures.
🤖 Generated with Claude Code