Skip to content

Move the profiles controller spec into the profile system spec - #1295

Merged
amatsuda merged 1 commit into
rubycentral:mainfrom
amatsuda:profiles_system_specs
Nov 19, 2026
Merged

amatsuda merged 1 commit into
rubycentral:mainfrom
amatsuda:profiles_system_specs

Conversation

@amatsuda

Copy link
Copy Markdown
Collaborator

Summary

Second per-file conversion. spec/controllers/profiles_controller_spec.rb is deleted; the only behaviour left in it was the incomplete-profile warning on the profile edit page.

spec/system/profile_spec.rb now checks that warning through the page with the an incomplete profile warning shared example from #1294 (six cases), plus the no-warning case for a complete profile.

The old controller-level shared example an incomplete profile notifier had no other users left and is removed too.

Test

Full suite locally: 695 examples, 0 failures.

🤖 Generated with Claude Code

The only behaviour left in it was the incomplete-profile warning on the
profile edit page. That now runs through the page with the shared example
introduced in the proposals conversion, plus the no-warning case for a
complete profile. The controller-level shared example had no other users
and goes with the controller spec.

Co-Authored-By: Claude Fable 5.1 <[email protected]>
@amatsuda
amatsuda merged commit ed75533 into rubycentral:main Nov 19, 2026
2 checks passed
@amatsuda
amatsuda deleted the profiles_system_specs branch November 19, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant