Repository navigation
Move the notifications controller spec into a request spec - #1297
Merged
Merged
Conversation
Two of its three examples were already covered through the pages in spec/system/notification_spec.rb: opening a notification marks it read, and "Mark all as read" clears them. The remaining one, a signed-out visitor being sent to the sign-in page, is HTTP plumbing with no page of its own, so it becomes a request spec. Co-Authored-By: Claude Fable 5.1 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fourth per-file conversion.
spec/controllers/notifications_controller_spec.rbis deleted.notification_spec"can click a notification to see and it is automatically marked as read"notification_spec"can mark all as read" (page) and "can mark all notifications as read from dropdown link"spec/requests/notifications_spec.rb: a signed-out visitor is sent to the sign-in pageTest
bin/rspec spec/requests/notifications_spec.rb spec/system/notification_spec.rb: 10 examples, 0 failures.🤖 Generated with Claude Code