Repository navigation
Move the teammates controller spec into the invitation system spec - #1298
Merged
Merged
Conversation
Accepting and declining a teammate invitation were already walked through in spec/system/staff/teammate_invitation_spec.rb, but those scenarios only looked at the flash. They now also check what the controller spec checked: accepting marks the invitation accepted and makes the user a reviewer for the event; declining marks it declined. Co-Authored-By: Claude Fable 5.1 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fifth per-file conversion.
spec/controllers/teammates_controller_spec.rbis deleted.spec/system/staff/teammate_invitation_spec.rbalready visits the accept and decline links as a signed-in user but only checked the flash. Its two scenarios now also assert what the controller spec did:Test
bin/rspec spec/system/staff/teammate_invitation_spec.rb: 18 examples, 0 failures.🤖 Generated with Claude Code