Skip to content

Move the staff proposals controller spec into the system spec - #1300

Merged
amatsuda merged 1 commit into
rubycentral:mainfrom
amatsuda:staff_proposals_system_specs
Nov 19, 2026
Merged

amatsuda merged 1 commit into
rubycentral:mainfrom
amatsuda:staff_proposals_system_specs

Conversation

@amatsuda

@amatsuda amatsuda commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

spec/controllers/staff/proposals_controller_spec.rb (7 examples) is deleted; spec/system/staff/proposals_spec.rb now covers the same behaviour as an organizer using the pages.

Controller example Now
show marks all notifications for this proposal as read new scenario on the review page. Notifications are matched to the page by full URL, so the scenario builds the notification's target for the host Capybara browses.
update changes the session format / the track (turbo_stream) two new JS scenarios using the inline pencil editors on the program proposal page; each asserts the saved value and the refreshed label
finalize finalizes the state already covered ("sets proposal state to accepted")
finalize creates a draft program session new example in the "Accepting a proposal" context
finalize sends appropriate emails already covered ("sends an email notification to the speaker"), without the mailer double
finalize creates a notification new example: the speaker gets an in-app notification

Test

Full suite locally: 693 examples, 0 failures.

🤖 Generated with Claude Code

Its seven examples now run through the staff pages as an organizer:

- opening a proposal's review page marks the organizer's notifications
  about it as read
- the inline format and track editors on the program proposal page save
  the new value and refresh the label
- finalizing an accepted proposal creates an unconfirmed-accepted program
  session and notifies the speaker in the app, alongside the existing
  checks of the state change and the email

Co-Authored-By: Claude Fable 5.1 <[email protected]>
@amatsuda
amatsuda merged commit 8e512de into rubycentral:main Nov 19, 2026
2 checks passed
@amatsuda
amatsuda deleted the staff_proposals_system_specs branch November 19, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant