Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedToo many files! This PR contains 155 files, which is 55 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.
|
Builds on the video-first Stage redesign (#71) and takes it across the whole site: a collapsible sidebar, an episode explorer on the home page, a player that stays with you between pages, and an episode page with a resizable stage. Shell - Collapsible sidebar that folds to an icon rail, with the hosts and the follow links in it. The fold is one PropFLIP flight over anchored auto layout, staggered with sibling-index(). - Search stays on Cmd/Ctrl+K and opens over anything, the player card included. Home - An episode explorer in place of the plain list: grid and list views, sort and filters, and a close-up with a filmstrip. Cards fly between views instead of cutting. Player - One media engine behind an island that is a dock, a pill, a corner picture or a full card with an Up next queue, and that survives client-side navigation. - The progress ship and its particles from the original player are on the island's scrubber. Episode page - A stage with Watch / Balanced / Read presets and a draggable divider, a sticky section bar, a live transcript, people cards and sponsors. Motion and state - motion/propflip.ts: FLIP flights with settle and viewport options. - prop-for-that publishes media state and pointer position as custom properties; pointer tracking is bound only while its element is hovered. - Scroll-state and anchor queries where supported, with plain fallbacks. Tests - Unit tests for the engine, queue, scrubber, flights and explorer query. - Playwright specs for the shell, explorer, player and episode page. Co-authored-by: Robert Wagner <[email protected]>
RobbieTheWagner
force-pushed
the
propflip-media-redesign
branch
from
November 18, 2026 02:44
f049899 to
a1070ea
Compare
Installing browsers with --with-deps pulled system packages from apt on every run and took 20+ minutes on a slow mirror; the tests then ran all three browsers serially on one worker. The image ships the browsers and their libraries, and each browser now runs in its own job with two workers. Co-Authored-By: Claude Opus 5.5 <[email protected]>
… there - Firefox doesn't scroll a partly hidden control into view on focus, so a card's artwork could sit under the sticky toolbar. The explorer brings it in with scrollIntoView, which honours the scroll margin everywhere. - The rail's synthetic throw used pointer id 1; Firefox's mouse is 0, and capturing another pointer throws, so the throw never started. - The close-up check measures both boxes on every poll, and allows the ~2px by which Firefox resolves anchor(top) above the slot. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Phones - Shell: gutters and bars clear the safe areas, one 48px tab bar in landscape, the rail starts collapsed. - Player: a docked 96x54 picture, a card that closes by chevron, grabber or swipe, 44px targets, contrast on every size. - Episode page: Watch is the default, section links land under the bar. Other browsers - Transcript timestamps take a mouse click: the speaker card opens from the name only and lets clicks through. - Up next lays out in WebKit 26 and Firefox as it does in Chrome, by naming the board's slots in style where typed attr() is missing. - Dragging a cover onto another slot reorders the queue everywhere. - Without anchor positioning the dock is the player's only home. - The section bar, reduced-motion section jumps and focus rings behave the same in Safari and Firefox. - The Watch / Balanced / Read control no longer trips a ResizeObserver loop. Explorer - The close-up opens at once, the archive comes back on one curve, and titles keep their wrap through a flight.
The toolbar sticks at the top and its first row fits 320px, the chip row steps aside while scrolling down, list rows show their whole facts line, the filter field no longer zooms the page on an iPhone, and the clear button takes a 44px tap.
Work in progress on three reports: the column beside the open card shifting on click, a returning card stopping short and then snapping, and no hover on the column's cards. Stopped mid-way and not checked by eye; revert this commit to return to the last verified explorer.
Explorer - Pressing a card in the column beside the open card leaves the column where it is; only keyboard focus scrolls a card into view. - A card returning to the list eases to its width instead of snapping: its perspective now hands back over the swap. - Cards grow on hover and keyboard focus, in the grid, the list and the column. - The grid/list switch folds away while a card is open. - On phones, Close and the cards no longer move out from under the finger, so the close-up can always be closed or swapped. Rail - Without typed attr(), one highlight slides between hovered, focused and current links, matching the old hover background.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes the video-first Stage redesign from #71 across the whole site, so the media stays at the centre wherever you are: a collapsible sidebar, an episode explorer on the home page, a player that follows you between pages, and an episode page with a resizable stage.
This branch was built on top of #71 and includes its three commits, squashed in here with @RobbieTheWagner credited as co-author. Merging this makes #71 redundant.
What changes
Shell
sibling-index().Home
Player
Episode page
Motion and state
src/motion/propflip.ts: FLIP flights, withsettleandviewportoptions. A flight no longer cancels the transitions an element lists in--also.Testing
pnpm lint: clean.pnpm test:unit: 229 passed.pnpm build(includesastro check): passes.Known gaps
episode.spec.ts"clicking a timestamp on episode 6 loads it into the player" fails on a cold dev server in Chromium and passes on retry.