Repository navigation
Conversation
sh-agents
marked this pull request as draft
November 19, 2026 08:31
sh-agents
marked this pull request as ready for review
November 19, 2026 15:38
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Received HTTP/2 data is limited to the advertised flow-control window: a peer that sends more is disconnected with GOAWAY
ENHANCE_YOUR_CALM. For this, http2 is upgraded to 5.4.13, together with tls 2.1.6, network 3.2 and warp 3.4.The tls upgrade of #1620 is continued here; it was stopped at a test failure between tls 2.1.6 and 2.1.7, so tls is pinned to 2.1.6.
Dependencies
index-state2023-12-12 → 2026-11-10. Unrelated packages are upgraded with it, among them postgresql-libpq 0.11, zlib 0.7, hspec 2.11.18 and http-client 0.7.19; on GHC 9.6.3, the boot packages directory, filepath, process, unix, Cabal and Cabal-syntax are built from Hackage; on GHC 8.10.7, process and Cabal.Code
ServerConfigandClientConfigand the limits of 4.2.2: 100 concurrent streams, stream and connection windows of 1048575 bytes. SETTINGS_MAX_FRAME_SIZE, advertised as 32759 by 4.2.2, is left at the 5.x default of 16384.confReadNTimeout = True, the read path of 4.2.2 is kept: reads are not timed out by http2.disconnectedaction called, when the connection is closed or lost: after a read error, at end of input, and when the reader of the connection is stopped by http2 after GOAWAY of the server.sendRequesttakes a handler, in which the body is read; in XFTP downloads, the file is written in it. ThesendReqfield ofHTTP2Clienthas the polymorphic typeH.SendRequest, so a response body can be read in its callback.sendRequestDirecthas the same signature; its response is read frombodyHead, as for APNs.closeTLSis limited to 1 s. It is changed in xftp-server: close stalled connections, reduce memory #2058 too, with the same implementation; the PR merged second is updated by merging master.VerifyDatavalue. The cipher names are changed in tls 2; the ciphers are the same (0x1303, 0xCCA9).Simplex.Messaging.Transportis compiled with-Wno-deprecations:getFinishedandgetPeerFinishedare deprecated in tls 2, andNothingis returned by their replacementgetTLSUniquefor TLS 1.3 sessions.Tests
runHTTP2Server: exactly the advertised window is accepted, and one more byte is answered with GOAWAYENHANCE_YOUR_CALM. Each expected frame is awaited for at most 5 s.testCloseBlockedTLS), which has the samecloseTLS.xftp, and the downloaded file was identical. An SMP connection was established between two agents throughsmp-server, and a message was delivered each way. TLS 1.3 with TLS_CHACHA20_POLY1305_SHA256 was negotiated in every pair.For simplex-chat
src/Simplex/Chat/Remote/Protocol.hs), the response body is read aftersendRequestDirectreturns. It has to be read in a callback ofsendReq, so that requests are sent concurrently with the event poll.simplex-chat.cabal: the bounds of http2 (>=4.2.2 && <4.3), network (>=3.1.2.7 && <3.2and==3.1.*), tls (>=1.9.0 && <1.10), websockets (==0.12.*) and warp (==3.3.*) are raised to the versions above.cabal.project: the sameindex-state; the warp pin of simplex-chat/wai and the warp-tls pin of yesodweb/wai removed.flake.nix: the sameindex-state, and thehackageinput inflake.lockupdated to a revision that includes 2026-11-10.scripts/nix/sha256map.nix: the entries of the removed wai pins deleted.