Repository navigation
names: signature JSON, ABI encoding and the repeated failure log for the names service - #2083
Draft
evgeny-simplex wants to merge 4 commits into
Draft
evgeny-simplex wants to merge 4 commits into
evgeny-simplex wants to merge 4 commits into
Conversation
…lowercase hex digits with a low s
…aller's message, the loop error shape the names service repeats
… bytes keep secret, so a config holding one derives Show
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simplex-chat/simplex-chat#8243 uses these changes: the names service's request decoding, its contract calls and its worker's logs.
RecoverableSignaturegets JSON instances by its string form (StrJSON), 0x and 130 lowercase hex digits with a low s, so that the service's request types derive their decoders (5c816f9).Simplex.Messaging.Ethbeside RLP, as anEncodinginstance with typed decoders of the return data, tested against the contracts' ABI; and one helper inSimplex.Messaging.Util, built oncatchOwn', for the log line "… failed; the next pass will run: " that 11 loops of the service repeat.simplex-chat's cabal.project references this branch's commit until this pull request is merged; scripts/nix/sha256map.nix is updated with the merged commit.