Repository navigation
Conversation
Adds one helper for the call-site migration from OpenTracing to the OpenTelemetry API. Wraps the bridge's tracer so an OpenTelemetry span started from a context nests under the OpenTracing span in it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## mwbrooks-tracer-otlp #825 +/- ##
========================================================
- Coverage 80.57% 80.56% -0.01%
========================================================
Files 246 246
Lines 18913 18914 +1
========================================================
- Hits 15239 15238 -1
- Misses 3674 3676 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…oks-tracer-start # Conflicts: # internal/tracer/tracer_test.go
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
N/A - internal refactor with no user-facing changes.
Summary
This pull request adds
tracer.Start, so maintainers have one pattern for moving eachopentracing.StartSpanFromContextcall to the OpenTelemetry API, package by package, in the next PRs.Startstarts a span fromotel.Tracer("slack-cli"), as a child of whatever span is inctxWrapperTracer. Without it, a span fromStartdoesn't see an OpenTracing parent inctxand starts a new traceStacked on #822.
Testing
go test ./internal/tracer/ -run Test_Start, which nests OpenTracing, then OpenTelemetry, then OpenTracing spans and checks each parent linkNotes
Test_Startfails without theWrapperTracerchange, with the OpenTelemetry span's parent emptyStartyet, so this changes no spans the CLI sends todayRequirements