Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## mwbrooks-otel-api-app #827 +/- ##
========================================================
Coverage ? 80.54%
========================================================
Files ? 246
Lines ? 18889
Branches ? 0
========================================================
Hits ? 15215
Misses ? 3674
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ooks-otel-api-datastore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
N/A - internal refactor with no user-facing changes.
Summary
This pull request moves the 11 spans in
internal/api/datastore.goandinternal/api/s3_upload.gofrom OpenTracing to the OpenTelemetry API, the next file in the move offopentracing-go.opentracing.StartSpanwithChildOfthe upload span. It now starts from the upload span's context withtracer.Start, so it keeps the same parentStacked on #826.
Testing
go test ./internal/api/Notes
AppsDatastoreCounttags the app ID under the keycount, notapp. This PR keeps the key, so it changes no span data. Renaming it can be its own PRRequirements