Repository navigation
fix(oci): keep the tag of a tag@digest Feature reference - #60
Merged
Merged
Conversation
Bump the pinned reference CLI to v0.90.0 and port its one source change (devcontainers/cli#1311): getRef now splits a tag off the resource of a `name:tag@sha256:…` reference, so `resource` no longer ends in `:tag` and `tag` is reported next to `digest`. The digest still selects the version. The ts-oracle getRef goldens gain the two upstream test inputs (a tag with a digest, and a registry port with both), regenerated from v0.90.0 with `task testdata:ts-oracle`; the existing `z:1@sha256:…` case now expects the split. The other goldens are unchanged under v0.90.0. v0.90.0's other fix is to its npm install script, which this CLI does not ship. The recorded divergence on a digest that fails the pattern (TS logs it and keeps the reference, ParseRef refuses it) stays. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the pinned reference CLI to v0.90.0 and ports its one source change.
v0.90.0 changes
getRefsplits the tag off aname:tag@sha256:…reference. Before,resourcekept:tagandtagwas empty. Ported ininternal/oci/ref.goParseRef.scripts/install.sh. That's upstream's npm installer, which this CLI doesn't ship. Not applicable.package.json/yarn.lock: nothing to port.Tests
internal/oci/testdata/ts-oracle/ref.jsongains upstream's two new test inputs (tag+digest, registry port+tag+digest), regenerated from v0.90.0 withtask testdata:ts-oracle. The existingghcr.io/x/y/z:1@sha256:…case changes to the split result.TestTSOracleReffails onmainfor all three and passes here.ParseRefrefuses it, because AGENTS.md forbids weakening validation.Docs/CI
README.md,docs/DIVERGENCES.md(#1213 and #881 are still unfixed upstream in v0.90.0) and the parity artifact names ingo-cli.yml.Validation (local)
task testdata:ts-oracle:check: pass.task lint: pass (0 issues,mutate -stale-exemptsOK).task test:racewithTMPDIRoutside/tmp: pass.task parity:contract: 104 pass. The 2read-configuration.features-configuration-local-feature-*cases fail locally because of a/tmp/.giton the dev machine (same onmain); CI is the check.🤖 Generated with Claude Code