Repository navigation
fix(cli): keep the config's ENV order in the single Dockerfile build - #71
Merged
Merged
Conversation
The one-build path for Dockerfile configurations (#70) built its Features stage without the config's containerEnv order, so those ENV lines came out sorted there while image configurations kept the declared order. A Dockerfile variant of the declaration-order parity case compares the built image with the reference. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#68 and #70 crossed: #70's single-build path for Dockerfile configurations (
buildDockerfileImage) builds its Features stage without the config'scontainerEnvorder that #68 added. So for a Dockerfile config, the config'sENVlines still came out sorted, while image configs kept the declared order.Fix: pass
ConfigEnvOrder: fb.ContainerEnvOrderthere, asextendImageWithFeaturesalready does.Test: new runtime parity case
build.dockerfile-features-env-declaration-order-success. It is the Dockerfile variant of #68's image case and compares the built image's env anddevcontainer-features.envwith TS. It fails without the one-line fix and passes with it; the image variant still passes.Validation (local):
task lint,task test:race(withTMPDIRoutside/tmp) andtask parity:contract(only the 2 known local/tmp/.gitcases fail).🤖 Generated with Claude Code