Repository navigation
refgen: a figure with no constant behind it is held by the text that decides it - #102
Merged
Merged
Conversation
…decides it Fourteen of the figures the pages say were listed as held by nothing: a session's seven days is a field's default, the metric store's backup a systemd timer, the retentions a composite literal, the proxy's record a Terraform local. A line may now name the text that decides the figure, in spin or the module, and the check fails when the file no longer has it, whatever its spacing. Eleven lines move to it; three stay unheld, each another party's fact or a variable's default among many. Co-Authored-By: Claude Fable 5.2 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#97 held 28 of the 51 figures the pages say to a Go constant of spin's, and listed 14 as held by nothing, because what decides them is not a constant: a field's default in a function, a systemd timer's unit, a composite literal, a line of a template, a Terraform local.
A line of
tools/refgen/figures.txtmay now name the text that decides the figure:task reference:checkfails when the file no longer has the text, whatever its spacing, naming the page to correct. It is weaker than reading a constant - a rename fails it too - and that is the right way round: it asks a person, where before nothing did.Eleven lines move to it. Three stay unheld, each saying why: the spot interruption notice is AWS's fact, the VS Code server's size is Microsoft's, and
object_lock_days' default is onedefault = 30among many in its file.A fork's pull request, with no spin checkout, checks the lines of spin-terraform-aws and leaves spin's to the run that has it.
task checkpasses locally.🤖 Generated with Claude Code