Repository navigation
feat: limit _helpers/ bucket counts and package and crate code lines - #135
Merged
Merged
Conversation
…er with per-path overrides
…Python content Python layout rules took the first configured root for every file, so in a target with several roots each root was measured against the first one. They now use the root that owns the file. The native check cache also hashes the content of Python files outside the evaluated set, which the code-line limit counts, so a change to one of them is no longer served from the cache.
kvlonge
enabled auto-merge (squash)
November 15, 2026 11:53
Deploying fensu with
|
| Latest commit: |
a5c2323
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3ae597f0.fensu.pages.dev |
| Branch Preview URL: | https://feat-container-and-crate-siz.fensu.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two size problems went unreported: a
_helpers/container could grow to a hundred or more buckets, and one package or crate could hold most of a codebase. Both hide missing boundaries, and an oversized Rust crate is rebuilt on every change.Changes
max_helpers_container_buckets(default 15): FFR312 (Python) and RSR312/FPRSR312 (Rust) report a_helpers/container with more buckets. A bucket is a direct subdirectory holding a source file; empty,__pycache__and asset-only folders do not count.max_crate_code_lines(default 75,000): FFR602 reports a top-level Python package, RSR602/FPRSR602 a crate at itsCargo.toml. Blank and comment-only lines do not count; Rust also skips doc comments,tests/targets, inline test trees and top-level#[cfg(test)]items.[thresholds]and path-scoped[[threshold_overrides]]for both limits.fensu-rustAPI:analyze_repositorytakes aThresholdLookup;analyze_repository_with_ownership_rootstakes aRepositoryAnalysisRequest. Rust cache contractrust-rules-v8.Verification
make check-ci,make test-rustandmake teston the final head.fensu check --no-cacheon this repository, three alternating runs each on one machine: median 1.36 s before, 1.41 s after, within noise.