Repository navigation
Conversation
…ata read errors History reads appended event_id to projections and orderings that already contained it, which Snowflake rejects as an ambiguous column. Select and order by it once, keeping each kind's fixed-length cursor. Failed metadata reads and warehouse connections now report the kind and the redacted driver error.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On Snowflake, warehouse history sync failed for the five event kinds whose columns already include
event_id. The read appendedevent_idto a projection and ordering that already had it, and Snowflake rejects the query with "ambiguous column name 'EVENT_ID'". DuckDB and SQLite accept the duplicate, so local tests passed. The location also discarded the error and printed only "Warehouse metadata read failed. No page delivered." with no reason.Changes
event_idonce. The cursor keeps its fixed length per kind (the trailing event ID repeats a key and is not used for ordering), so the read protocol is unchanged.event_idcolumn when the kind already has one.Verification
DuckShop: no new case. Its existing edge-case fixtures for these kinds already cover the table shape, and the rejection only occurs on Snowflake.