Skip to content

fix(deps): pin SQLQuack 0.11.1 - #78

Merged
kvlonge merged 1 commit into
mainfrom
fix/pin-sqlquack-0-11-1
Nov 13, 2026
Merged

kvlonge merged 1 commit into
mainfrom
fix/pin-sqlquack-0-11-1

Conversation

@kvlonge

@kvlonge kvlonge commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Why

SQLQuack 0.11.1 is published. Its lint reads a bare FIRST or LAST after a joined table as that table's alias, so SQLCLEAN032 (joined relation contributes nothing) and SQLCLEAN022 (no stable output name) stop firing on first.x and last.x in Snowflake. SQLClean and SQLBuild link one SQLQuack, so SQLClean moves first.

Changes

  • All six direct sqlquack-* pins in Cargo.toml move from 9f08cb59 (0.11.0) to 62642bc1 (0.11.1). Cargo.lock updates only the SQLQuack packages.
  • No formatter, lint or fixture changes are needed.

Verification

  • cargo test --all passes (40 + 8 tests), including the format corpus test, whose layouts and refusal counts are unchanged. The T-SQL lint test stays ignored.
  • make check-ci passes.
  • Compared the 0.9.3 release with this build using sqlclean check --no-cache --select SQLCLEAN032,SQLCLEAN022 on Snowflake files:
    • JOIN order_events first ON first.order_id = …, LEFT JOIN order_events last USING (order_id) and CROSS JOIN products first, each selecting first.x or last.x: 0.9.3 reports both codes; this build reports nothing.
    • Controls: an ordinary alias passes on both, and a join whose alias is never referenced still reports SQLCLEAN032 on both.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying sqlclean with  Cloudflare Pages  Cloudflare Pages

Latest commit: c137067
Status: ✅  Deploy successful!
Preview URL: https://58c0238c.sqlclean.pages.dev
Branch Preview URL: https://fix-pin-sqlquack-0-11-1.sqlclean.pages.dev

View logs

@kvlonge
kvlonge merged commit 2b64bb3 into main Nov 13, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant